Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl: 7.61.1 -> 7.62.0 (security) #50279

Closed
wants to merge 1 commit into from
Closed

curl: 7.61.1 -> 7.62.0 (security) #50279

wants to merge 1 commit into from

Conversation

florianjacob
Copy link
Contributor

The package curl before version 7.62.0 is vulnerable to multiple issues
including arbitrary code execution and information disclosure:
https://curl.haxx.se/changes.html#7_62_0

This should also be backported to 18.09.

Maintainer: @lovek323

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@florianjacob
curl: 7.61.1 -> 7.62.0
919bae6 
The package curl before version 7.62.0 is vulnerable to multiple issues
including arbitrary code execution and information disclosure:
https://curl.haxx.se/changes.html#7_62_0
@florianjacob
Copy link
Contributor Author

@GrahamcOfBorg build curl

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 12, 2018

It's already in staging : #49514

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: curl

Partial log (click to expand)

patching script interpreter paths in /nix/store/z2dk19f6sahh4m6qqg3nsm2jxfb0nzw0-curl-7.62.0-man
checking for references to /build in /nix/store/z2dk19f6sahh4m6qqg3nsm2jxfb0nzw0-curl-7.62.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/mvq1a2gyr4kym6b6h2qsn3gizdkw95jz-curl-7.62.0-devdoc
gzipping man pages under /nix/store/mvq1a2gyr4kym6b6h2qsn3gizdkw95jz-curl-7.62.0-devdoc/share/man/
patching script interpreter paths in /nix/store/mvq1a2gyr4kym6b6h2qsn3gizdkw95jz-curl-7.62.0-devdoc
checking for references to /build in /nix/store/mvq1a2gyr4kym6b6h2qsn3gizdkw95jz-curl-7.62.0-devdoc...
shrinking RPATHs of ELF executables and libraries in /nix/store/s21j9bs7xj48kv3vpihh6vzh62jzlf50-curl-7.62.0-debug
patching script interpreter paths in /nix/store/s21j9bs7xj48kv3vpihh6vzh62jzlf50-curl-7.62.0-debug
checking for references to /build in /nix/store/s21j9bs7xj48kv3vpihh6vzh62jzlf50-curl-7.62.0-debug...
/nix/store/jnman3ksmqvd3rynkdgcbsmw0rbbx8ka-curl-7.62.0-bin

@florianjacob
Copy link
Contributor Author

Damn, forgot to check staging. @c0bw3b thanks!

@florianjacob florianjacob deleted the curl branch November 12, 2018 18:34
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: curl

Partial log (click to expand)

patching script interpreter paths in /nix/store/zr9m7hngklwzbpxcbn1i5bn9fmcskagz-curl-7.62.0-man
checking for references to /build in /nix/store/zr9m7hngklwzbpxcbn1i5bn9fmcskagz-curl-7.62.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/x8qjxxps1b21ly0yd6ymnmi5fjwk4y5q-curl-7.62.0-devdoc
gzipping man pages under /nix/store/x8qjxxps1b21ly0yd6ymnmi5fjwk4y5q-curl-7.62.0-devdoc/share/man/
patching script interpreter paths in /nix/store/x8qjxxps1b21ly0yd6ymnmi5fjwk4y5q-curl-7.62.0-devdoc
checking for references to /build in /nix/store/x8qjxxps1b21ly0yd6ymnmi5fjwk4y5q-curl-7.62.0-devdoc...
shrinking RPATHs of ELF executables and libraries in /nix/store/djzc5iy65m3cmwhakmapa4pdvbdg08i7-curl-7.62.0-debug
patching script interpreter paths in /nix/store/djzc5iy65m3cmwhakmapa4pdvbdg08i7-curl-7.62.0-debug
checking for references to /build in /nix/store/djzc5iy65m3cmwhakmapa4pdvbdg08i7-curl-7.62.0-debug...
/nix/store/ffzgjvcplq2x1mrz7q94nrbikryz9jl5-curl-7.62.0-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: curl

Partial log (click to expand)

/nix/store/ffzgjvcplq2x1mrz7q94nrbikryz9jl5-curl-7.62.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: curl

Partial log (click to expand)

patching script interpreter paths in /nix/store/z2dk19f6sahh4m6qqg3nsm2jxfb0nzw0-curl-7.62.0-man
checking for references to /build in /nix/store/z2dk19f6sahh4m6qqg3nsm2jxfb0nzw0-curl-7.62.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/mvq1a2gyr4kym6b6h2qsn3gizdkw95jz-curl-7.62.0-devdoc
gzipping man pages under /nix/store/mvq1a2gyr4kym6b6h2qsn3gizdkw95jz-curl-7.62.0-devdoc/share/man/
patching script interpreter paths in /nix/store/mvq1a2gyr4kym6b6h2qsn3gizdkw95jz-curl-7.62.0-devdoc
checking for references to /build in /nix/store/mvq1a2gyr4kym6b6h2qsn3gizdkw95jz-curl-7.62.0-devdoc...
shrinking RPATHs of ELF executables and libraries in /nix/store/s21j9bs7xj48kv3vpihh6vzh62jzlf50-curl-7.62.0-debug
patching script interpreter paths in /nix/store/s21j9bs7xj48kv3vpihh6vzh62jzlf50-curl-7.62.0-debug
checking for references to /build in /nix/store/s21j9bs7xj48kv3vpihh6vzh62jzlf50-curl-7.62.0-debug...
/nix/store/jnman3ksmqvd3rynkdgcbsmw0rbbx8ka-curl-7.62.0-bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@florianjacob @c0bw3b @GrahamcOfBorg