Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flashplayer: 31.0.0.122 -> 31.0.0.153 #50839

Merged
merged 1 commit into from Nov 20, 2018

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Nov 20, 2018

Motivation for this change

The release notes are not updated yet.

https://helpx.adobe.com/flash-player/release-note/fp_31_air_31_release_notes.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Fits CONTRIBUTING.md.

  • Built packages

    • nix-env -i -f . -A pkgs.flashplayer
    • nix-build -I nixpkgs=. -A pkgsi686Linux.flashplayer
    • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).flashplayer.override { debug = true; }"
    • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).pkgsi686Linux.flashplayer.override { debug = true; }"
    • nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone
    • nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone-debugger
    • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).chromium.override { enablePepperFlash = true; }"
  • Played a video with Firefox and Chromium (x86_64).

  • Checked the version with Firefox, Chromium, flashplayer-standalone, and flashplayer-standalone-debugger (x86_64) http://www.adobe.com/software/flash/about/


@7c6f434c 7c6f434c merged commit d3bdf3f into NixOS:master Nov 20, 2018
7c6f434c added a commit that referenced this pull request Nov 20, 2018
flashplayer: 31.0.0.122 -> 31.0.0.153
(cherry picked from commit d3bdf3f)
@7c6f434c
Copy link
Member

18.09: f7da99c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants