Add: Unique ID to savegames to prevent accidental overwriting #6973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damfr
force-pushed
the
save-unique-id
branch
from
610c10d
to
86284bf
Compare
nielsmh
reviewed
Nov 20, 2018
damfr
force-pushed
the
save-unique-id
branch
from
86284bf
to
bdd47ed
Compare
nielsmh
reviewed
Nov 24, 2018
damfr
force-pushed
the
save-unique-id
branch
from
bdd47ed
to
c87a1a8
Compare
frosch123
previously requested changes
Nov 25, 2018
damfr
force-pushed
the
save-unique-id
branch
from
c87a1a8
to
5d8b9de
Compare
nielsmh
dismissed
frosch123’s stale review
Savegame version on setting corrected
|
We recently switched from Jenkins as CI to Azure Pipelines as CI. This means you need to rebase before this Pull Request will pass its checks. Sorry for the troubles! |
|
Closing in favor of #7128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new randomly generated unique ID as a setting to savegames to avoid accidental overwriting of another savegame in the save dialog.
The ID is automatically generated :
When the user attempts to overwrite a save with a different ID, a warning popup shows and a message is also shown in the details of the save.