openssl: security updates #50846
Merged
openssl: security updates #50846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
They are low-severity, and probably staging should be ok. |
|
Failure on x86_64-linux (full log) Attempted: openssl, openssl_1_1 Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: openssl, openssl_1_1 Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: openssl, openssl_1_1 Partial log (click to expand)
|
fpletz
approved these changes
Nov 20, 2018
There was a problem hiding this comment.
I agree. The moderate severity issues are either not applicable (no PA-RISC support) or theoretical. The low severity issues are IMHO not even worth backporting.
Debian is also not backporting and waiting for the next release: https://security-tracker.debian.org/tracker/source-package/openssl
|
@alyssais The build is failing. Could you take another look at the patch? |
|
Failure on x86_64-linux (full log) Attempted: openssl, openssl_1_1 Partial log (click to expand)
|
|
Looks like they've changed the formatting in 1.1.1 so we can't use the same patch for both anymore… |
CVE-2018-0734: https://www.openssl.org/news/vulnerabilities.html#2018-0734 CVE-2018-5407: https://www.openssl.org/news/vulnerabilities.html#2018-5407 No patches can any longer be shared between 1.0.2 and 1.1, so reorganize patches into subdirectories (and remove an unused one).
|
Success on aarch64-linux (full log) Attempted: openssl, openssl_1_1 Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: openssl, openssl_1_1 Partial log (click to expand)
|
9 tasks
dtzWill
added a commit
to dtzWill/nixpkgs
that referenced
this pull request
Nov 20, 2018
Use upstream NixOS#50846 for openssl updates, instead. Thanks! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Was unsure if this PR should have been to master or staging given the security impact.
CVE-2018-0734: https://www.openssl.org/news/vulnerabilities.html#2018-0734
CVE-2018-0735: https://www.openssl.org/news/vulnerabilities.html#2018-0735
CVE-2018-5407: https://www.openssl.org/news/vulnerabilities.html#2018-5407
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)