Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archiver: init at 3.0.0 #49956

Merged
merged 1 commit into from Nov 9, 2018
Merged

archiver: init at 3.0.0 #49956

merged 1 commit into from Nov 9, 2018

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Nov 8, 2018 •
edited

Motivation for this change

Archiver is a pretty useful tool with no dependencies for creating and extracting many types of archives.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@kalbasit
Copy link
Member Author

kalbasit commented Nov 8, 2018

@GrahamcOfBorg build archiver

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: archiver

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xzijjjs368srmkh0rrlz71f9y2wka5m8-archiver-3.0.0-bin
shrinking /nix/store/xzijjjs368srmkh0rrlz71f9y2wka5m8-archiver-3.0.0-bin/bin/arc
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xzijjjs368srmkh0rrlz71f9y2wka5m8-archiver-3.0.0-bin/bin
patching script interpreter paths in /nix/store/xzijjjs368srmkh0rrlz71f9y2wka5m8-archiver-3.0.0-bin
checking for references to /build in /nix/store/xzijjjs368srmkh0rrlz71f9y2wka5m8-archiver-3.0.0-bin...
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
/nix/store/xzijjjs368srmkh0rrlz71f9y2wka5m8-archiver-3.0.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: archiver

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/f5hdh6zigf4vsds8bgb71s5br22syqr7-archiver-3.0.0-bin
shrinking /nix/store/f5hdh6zigf4vsds8bgb71s5br22syqr7-archiver-3.0.0-bin/bin/arc
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/f5hdh6zigf4vsds8bgb71s5br22syqr7-archiver-3.0.0-bin/bin
patching script interpreter paths in /nix/store/f5hdh6zigf4vsds8bgb71s5br22syqr7-archiver-3.0.0-bin
checking for references to /build in /nix/store/f5hdh6zigf4vsds8bgb71s5br22syqr7-archiver-3.0.0-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/f5hdh6zigf4vsds8bgb71s5br22syqr7-archiver-3.0.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: archiver

Partial log (click to expand)

/nix/store/f5hdh6zigf4vsds8bgb71s5br22syqr7-archiver-3.0.0-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: archiver

Partial log (click to expand)

/nix/store/xzijjjs368srmkh0rrlz71f9y2wka5m8-archiver-3.0.0-bin

@kalbasit
Copy link
Member Author

kalbasit commented Nov 9, 2018

@c0bw3b done, PTAL.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: archiver

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xzijjjs368srmkh0rrlz71f9y2wka5m8-archiver-3.0.0-bin
shrinking /nix/store/xzijjjs368srmkh0rrlz71f9y2wka5m8-archiver-3.0.0-bin/bin/arc
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xzijjjs368srmkh0rrlz71f9y2wka5m8-archiver-3.0.0-bin/bin
patching script interpreter paths in /nix/store/xzijjjs368srmkh0rrlz71f9y2wka5m8-archiver-3.0.0-bin
checking for references to /build in /nix/store/xzijjjs368srmkh0rrlz71f9y2wka5m8-archiver-3.0.0-bin...
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
/nix/store/xzijjjs368srmkh0rrlz71f9y2wka5m8-archiver-3.0.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: archiver

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/f5hdh6zigf4vsds8bgb71s5br22syqr7-archiver-3.0.0-bin
shrinking /nix/store/f5hdh6zigf4vsds8bgb71s5br22syqr7-archiver-3.0.0-bin/bin/arc
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/f5hdh6zigf4vsds8bgb71s5br22syqr7-archiver-3.0.0-bin/bin
patching script interpreter paths in /nix/store/f5hdh6zigf4vsds8bgb71s5br22syqr7-archiver-3.0.0-bin
checking for references to /build in /nix/store/f5hdh6zigf4vsds8bgb71s5br22syqr7-archiver-3.0.0-bin...
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/f5hdh6zigf4vsds8bgb71s5br22syqr7-archiver-3.0.0-bin

@c0bw3b c0bw3b merged commit f0dc3b6 into NixOS:master Nov 9, 2018
@kalbasit kalbasit deleted the nixpkgs_add-archiver branch November 9, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalbasit @GrahamcOfBorg @c0bw3b