openconnect-globalprotect: init at 7.08 #49927
Conversation
| description = "VPN Client for Cisco's AnyConnect SSL VPN"; | ||
| homepage = http://www.infradead.org/openconnect/; | ||
| license = stdenv.lib.licenses.lgpl21; | ||
| maintainers = with stdenv.lib.maintainers; [ pradeepchhetri ]; |
There was a problem hiding this comment.
Is this you, or did you agree with this person to add them as a maintainer? :)
| stdenv.mkDerivation rec { | ||
| name = "openconnect-globalprotect-7.08"; | ||
|
|
||
| src = fetchGit { |
There was a problem hiding this comment.
Please use fetchFromGitHub here :)
| ref = "globalprotect"; | ||
| }; | ||
|
|
||
| outputs = [ "out" "dev" ]; |
There was a problem hiding this comment.
Does this really create a meaningful dev output? What does it include?
| ]; | ||
|
|
||
| nativeBuildInputs = [ autoconf automake pkgconfig libtool ]; | ||
| propagatedBuildInputs = [ vpnc openssl gnutls gmp libxml2 stoken zlib ]; |
There was a problem hiding this comment.
Some of these seem very surprising to me. Why is zlib propagated for example? What's it needed by?
| @@ -5980,6 +5980,16 @@ with pkgs; | |||
| openssl = null; | |||
| }; | |||
|
|
|||
| openconnect-globalprotect = openconnect-globalprotect_gnutls; | |||
There was a problem hiding this comment.
I think this attribute will be enough for the top level, and leave the rest of the configuration to overrides. Three versions seems a bit much.
| gnutls = null; | ||
| }; | ||
|
|
||
| openconnect-globalprotect_gnutls = callPackage ../tools/networking/openconnect-globalprotect { |
There was a problem hiding this comment.
why would we need both openssl and gnutls?
|
Note that latest release 8.0+ of openconnect includes the globalprotect protocol so this should not be needed. http://www.infradead.org/openconnect/changelog.html. That said we still need openconnect to be updated to the latest release. |
|
8.02 was merged in master with #54060 |
Janik-Haag
added
the
12. first-time contribution
Motivation for this change
openconnectdoesn't support GlobalProtect out of the box, the fork of dlenski does.Note that AUR also has this package, under the name openconnect-palo.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)