New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildbot: 1.4.0 -> 1.8.1 #52536
buildbot: 1.4.0 -> 1.8.1 #52536
Conversation
2513c1b
to
7d57089
Compare
1.7.0 has been released, so this PR now updates buildbot to this version. |
7d57089
to
2d8473d
Compare
2d8473d
to
241898e
Compare
1.8.0 has been released, so this PR now updates buildbot to this version. A change to SQLite broke sqlalchemy-migrate, which was causing the tests to fail. This PR includes an update of sqlalchemy-migrate to 0.12.0 which fixes the issue. Therefore buildbot's tests have been re-enabled. |
This comment has been minimized.
This comment has been minimized.
@lopsided98 Can you please update this to at least 1.8.1. That would fix https://github.com/buildbot/buildbot/wiki/CRLF-injection-in-Buildbot-login-and-logout-redirect-code then |
241898e
to
7de9005
Compare
I updated to 1.8.1. I don't have time to do the update to 2.0.0 update right now since it requires changes to the tests and possibly the NixOS module (because it drops support for Python 2). Maybe this PR should just be merged and then I'll create a new one for the update to 2.0.0? |
@lopsided98 Yes, I had the same idea. @GrahamcOfBorg build python2Packages.buildbot python2Packages.buildbot-full |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Motivation for this change
Update all of buildbot to 1.8.0 (the master package had previously been updated to 1.5.0), and make it build again.
Things done
I also disabled buildbot's tests due to some failures. These failures were not caused by the upgrade to 1.7.0, but already occurred with 1.4.0. They are likely due to an upgrade of a dependency. I tried to bisect, but buildbot was previously broken because some of its dependencies failed to build, so I could not figure out when the tests started to fail.I ran the NixOS tests and they passed.
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)