openra: 20180923->20181215 #52531
Merged
openra: 20180923->20181215 #52531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let us /CC @rardiol, the maintainer. |
FRidh
approved these changes
Dec 20, 2018
|
Sorry for taking so long, seems fine to me ( but I didn't test multiplayer either). |
Synthetica9
reviewed
Dec 23, 2018
pkgs/games/openra/default.nix
Outdated
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| stdenv.mkDerivation rec { | |||
| name = "openra-${version}"; | |||
There was a problem hiding this comment.
Suggested change
| name = "openra-${version}"; | |
| pname = "openra"; |
There was a problem hiding this comment.
OK, although this has nothing to do with the topic of this PR, nor my original commit, I didn't change this line, after all. But, I suppose might as well incorporate as many minor improvements as possible in this PR while we're at it.
fusion809
force-pushed
the
openra-20181215-bump
branch
from
f0576c8
to
2df9920
Compare
|
@GrahamcOfBorg build openra |
|
OK, well all checks have passed, so whom wishes to give their tick of approval and perhaps even merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
OpenRA is out of date and it needs to be updated, simple as that.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)I have tried out all three mods and all three work fine, at least in single player mode (haven't tried multiplayer as I have never played a multiplayer game).