Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomachine-client: Fix audio support and update 6.3.6_1 -> 6.4.6_1 #52522

Merged
merged 2 commits into from Dec 19, 2018
Merged

nomachine-client: Fix audio support and update 6.3.6_1 -> 6.4.6_1 #52522

merged 2 commits into from Dec 19, 2018

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Dec 19, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz
nomachine-client: 6.3.6_1 -> 6.4.6_1
1fc12ef
@talyz
nomachine-client: Fix audio support
aaf353e 
libnxcau.so needs libpulse.so.0 for audio to work, but doesn't
have a DT_NEEDED entry for it, so it's not automatically
detected. This adds the missing entry and libpulseaudio to
buildInputs, enabling autoPatchelfHook to fix the RPATH.
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 19, 2018

So audio works for you too @talyz ? (just double-checking)

@talyz
Copy link
Contributor Author

talyz commented Dec 19, 2018

Yes, commit aaf353e fixes audio for me.

@c0bw3b c0bw3b merged commit 42d37e4 into NixOS:master Dec 19, 2018
@c0bw3b c0bw3b mentioned this pull request Dec 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@talyz @c0bw3b @GrahamcOfBorg