Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.jupytext: init at 0.8.4 #52545

Merged
merged 1 commit into from Dec 20, 2018
Merged

pythonPackages.jupytext: init at 0.8.4 #52545

merged 1 commit into from Dec 20, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Dec 19, 2018

Motivation for this change

Trying to work with a jupyter notebook without having to deal with the web interface.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner December 19, 2018 22:20
@timokau
Copy link
Member Author

timokau commented Dec 19, 2018

@GrahamcOfBorg build python2.pkgs.jupytext python3.pkgs.jupytext

@timokau
Copy link
Member Author

timokau commented Dec 19, 2018

The dependency failures are due to a flaky path.py test (#52548). I wonder why it is now suddenly acting up on hydra and ofborg. Maybe there was some performance decrease, but that is hard to quantify deterministically.

@timokau timokau merged commit 51fdee8 into NixOS:master Dec 20, 2018
@timokau timokau deleted the jupytext-init branch December 20, 2018 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg