Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant-cli: init at 0.3.0 #52527

Merged
merged 1 commit into from Dec 20, 2018
Merged

home-assistant-cli: init at 0.3.0 #52527

merged 1 commit into from Dec 20, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @peterhoeg @fpletz
Feel free to notify other Home Assistant users, this seems like a nice addition to the ecosystem.

@peterhoeg
Copy link
Member

I had this on my list to package, so 👍 from here!

@fpletz
Copy link
Member

fpletz commented Dec 20, 2018

Cool! 👍

@fpletz fpletz merged commit 25eb841 into NixOS:master Dec 20, 2018
@peterhoeg
Copy link
Member

I can't build it here - install tests fail. Only works with doCheck = false;.

@fpletz
Copy link
Member

fpletz commented Dec 20, 2018

Weird, worked for me.

@dotlambda
Copy link
Member Author

I don't see any issue: https://hydra.nixos.org/eval/1496677?filter=home-assistant&compare=1496636&full=

@peterhoeg Do you have a log?

@peterhoeg
Copy link
Member

On unstable with the commit cherry-picked:

https://gist.github.com/peterhoeg/138ef25d816ae458435d7cec89683d2a

@dotlambda
Copy link
Member Author

I think there has been a click update that was merged in the meantime (between unstable and master). You probably need at least that.

@dotlambda dotlambda deleted the home-assistant-cli-0.3.0 branch March 21, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @peterhoeg @fpletz @GrahamcOfBorg