Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shades-of-gray-theme: 1.1.1 -> 1.1.3 #52521

Merged
merged 1 commit into from Dec 19, 2018
Merged

shades-of-gray-theme: 1.1.1 -> 1.1.3 #52521

merged 1 commit into from Dec 19, 2018

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Dec 19, 2018

Motivation for this change
  • Update to version 1.1.3
  • Move to pkgs/data/themes
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

c0bw3b
c0bw3b approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@c0bw3b c0bw3b merged commit 7e56679 into NixOS:master Dec 19, 2018
@romildo romildo deleted the upd.shades-of-gray branch December 19, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @c0bw3b @GrahamcOfBorg