Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pathpy: skip performance test #52548

Merged
merged 1 commit into from Dec 19, 2018
Merged

pythonPackages.pathpy: skip performance test #52548

merged 1 commit into from Dec 19, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Dec 19, 2018

Motivation for this change

The test may fail non-deterministically, as it does right now on hydra.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
pythonPackages.pathpy: skip performance test
bc869bd 
The test may fail non-deterministically, as it does right now on hydra.
@timokau timokau requested a review from FRidh as a code owner December 19, 2018 22:37
@timokau
Copy link
Member Author

timokau commented Dec 19, 2018

@GrahamcOfBorg build python2.pkgs.pathpy python3.pkgs.pathpy

@timokau timokau mentioned this pull request Dec 19, 2018
Merged
10 tasks
@timokau timokau merged commit 979b88b into NixOS:master Dec 19, 2018
@timokau timokau deleted the pathpy-fix branch December 19, 2018 22:53
@timokau
Copy link
Member Author

timokau commented Dec 19, 2018

Oh just noticed the rebuild count. I think with 101-500 and most of them probably light python packages, I should be able to get away without staging.

@timokau
Copy link
Member Author

timokau commented Dec 19, 2018

Oh and all of those packages probably failed on the most recent build, so that should be worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg