Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib: 2.58.1 -> 2.58.2 #52539

Merged
merged 1 commit into from Dec 26, 2018
Merged

glib: 2.58.1 -> 2.58.2 #52539

merged 1 commit into from Dec 26, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 19, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

At least works properly with the gnome-y bits I used on my laptop, FWIW.

@hedning
Copy link
Contributor

hedning commented Dec 19, 2018

Changelog: https://gitlab.gnome.org/GNOME/glib/blob/97bcbcb8c2aa0aeee5afd9939efbadbae0c8a8fa/NEWS

Breaks a test on i686: https://gitlab.gnome.org/GNOME/glib/issues/1626

@jtojnar jtojnar mentioned this pull request Dec 26, 2018
Closed
@jtojnar
Copy link
Contributor

jtojnar commented Dec 26, 2018

nix-build -A glib --argstr system i686-linux fails on coreutils tests erroring out so the patch is pointless at the moment.

@jtojnar jtojnar merged commit 1122e65 into NixOS:staging Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @hedning @jtojnar @GrahamcOfBorg