Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iasl: 20180313 -> 20181213; patch xen to work with new acpica-tools #52541

Merged
merged 2 commits into from Jan 16, 2019
Merged

iasl: 20180313 -> 20181213; patch xen to work with new acpica-tools #52541

merged 2 commits into from Jan 16, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 19, 2018

Motivation for this change

Uses upstream commit for the patch.

Not sure how to best build-test all the xen bits,
notably this may not work on all versions?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from xeji January 5, 2019 19:57
@xeji
Copy link
Contributor

xeji commented Jan 6, 2019

@GrahamcOfBorg build xen_4_10

@xeji
Copy link
Contributor

xeji commented Jan 6, 2019

xen looks fine. Let's try some more builds:
@GrahamcOfBorg build virtualbox gnome3.gnome-boxes OVMF

@xeji
Copy link
Contributor

xeji commented Jan 6, 2019 •
edited

The xen patch was merged upstream in both xen 4.8.5 and 4.10.2, so it should be fine, and it can be removed on the next xen version bump.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 16, 2019

Thanks!!

@dtzWill dtzWill merged commit 94a8a9b into NixOS:master Jan 16, 2019
@dtzWill dtzWill deleted the update/iasl-2018-and-xen-fix branch January 16, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @xeji @GrahamcOfBorg