Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.absl-py: fix python2 build #52544

Merged
merged 1 commit into from Dec 19, 2018
Merged

pythonPackages.absl-py: fix python2 build #52544

merged 1 commit into from Dec 19, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Dec 19, 2018

Motivation for this change

The python2 build was broken by the last absl-py update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau timokau requested a review from FRidh as a code owner December 19, 2018 21:55
@Mic92
Copy link
Member

Mic92 commented Dec 19, 2018

@GrahamcOfBorg build pythonPackages.absl-py python3Packages.absl-py

@timokau
Copy link
Member Author

timokau commented Dec 19, 2018

Darwin failure looks like a builder issue.

@timokau timokau merged commit af83f8b into NixOS:master Dec 19, 2018
@timokau timokau deleted the absl-py-fix branch December 19, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @Mic92 @GrahamcOfBorg