Skip to content

Use Interactive bash for GCE #51495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2018
Merged

Use Interactive bash for GCE #51495

merged 1 commit into from
Dec 5, 2018
+2 −1

Conversation

dingxiangfei2009
Copy link
Contributor

Motivation for this change

Fix #40428. This allows accounts created by GCE to use an interactive Bash instead.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Mic92
Mic92 reviewed Dec 4, 2018
View reviewed changes
pkgs/tools/virtualization/google-compute-engine/default.nix
@@ -25,7 +25,7 @@ buildPythonApplication rec {
for file in $(find google_compute_engine -type f); do
substituteInPlace "$file" \
--replace /bin/systemctl "${systemd}/bin/systemctl" \
--replace /bin/bash "${bash}/bin/bash" \
--replace /bin/bash "${bashInteractive}/bin/bash" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also replace this in the header of this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forget to push my local changes...

@dingxiangfei2009 dingxiangfei2009 force-pushed the use-interactive-bash-for-gce branch from b85c7a9 to 3c667a8 Compare December 5, 2018 01:46
@dingxiangfei2009 dingxiangfei2009 force-pushed the use-interactive-bash-for-gce branch from 3c667a8 to f4414da Compare December 5, 2018 01:47
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 5, 2018
@Mic92 Mic92 merged commit caaaaa7 into NixOS:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dingxiangfei2009 @Mic92 @GrahamcOfBorg