Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-{zsh,bash}-completions version bump #51497

Merged
merged 2 commits into from Dec 4, 2018
Merged

nix-{zsh,bash}-completions version bump #51497

merged 2 commits into from Dec 4, 2018

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Dec 4, 2018

Motivation for this change

Adds nixos-option completion thanks to @Ma27. Also adds full completion to nix-prefetch-url so it's now easy to do nix-prefetch-url -A nam<tab>, in addition to a few bug fixes.

bash changelog: https://github.com/hedning/nix-bash-completions/releases/tag/v0.6.7
zsh changelog: https://github.com/spwhitt/nix-zsh-completions/releases/tag/0.4.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Ma27
Ma27 approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for releasing the changes so fast 👍

@Ma27 Ma27 merged commit 37f0a4f into NixOS:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hedning @Ma27 @GrahamcOfBorg