Thanks for this.
One remarks though: this module is doing things wrong, somewhat.
mediawiki should be a derivation (ie package) living under pkgs, and the service module should rely on this package. At least that's how the majority of service modules are written.
(plus it would allow someone on non-nixos or with a different setup to still install mediawiki through nix without automatically setting it up as a service)

Thanks for this.
One remarks though: this module is doing things wrong, somewhat.
mediawiki should be a derivation (ie package) living under pkgs, and the service module should rely on this pkgs. At least that's how the majority of service modules are written.
(plus it would allow some on non-nixos or with a different setup to still install mediawiki through nix without automatically setting it up as a service)

I'm happy to do this but to be honest that's probably above my 'pay grade' with respect to doing it properly in a timely manner (I'm still very much at the 'cargo cult'-stage of NixOS contributions).

I'm happy to do this and raise another PR with this change and maintain the new package after this one is pushed.

I just wanted to get the update in as it was with the minimal changes for obvious reasons.

This module is probably not fully functional anymore. The postgresql init may fail because it tries to run as root instead of the postgresql super user.

This module is probably not fully functional anymore. The postgresql init may fail because it tries to run as root instead of the postgresql super user.

That is correct for new installations. For existing installations which would get the security update they would continue as the table updates are done as the user configured in your configuration.nix.

I'm in the process of writing up docs to do a basic installation.

The howto covers that as:

[code]
su - postgres
createuser --interactive root

** rebuild goes here **

dropuser root
[/code]

Is that good? no.
Does it need to be fixed? yes.

It was on the list of things I was going to work on post-update.

It should be enough to add -U postgresql to the commands in the init script.

I think the update of the module logic should be part of a second PR, this one is only about a security patch of mediawiki.

Agreed @makefu and that is what @redvers propose to do
So merging this to begin with.