Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noto-fonts: update 2017-10-24 -> 2018-11-30 #51500

Merged
merged 1 commit into from Dec 6, 2018
Merged

noto-fonts: update 2017-10-24 -> 2018-11-30 #51500

merged 1 commit into from Dec 6, 2018

Conversation

colemickens
Copy link
Member

Motivation for this change

Update the Noto fonts, particularly to avoid an old ligature issue. Fixes: #51498.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 4, 2018

@GrahamcOfBorg build noto-fonts

@Mic92
Copy link
Member

Mic92 commented Dec 4, 2018 

fixed-output derivation produced path '/nix/store/44l43pfm338impslqnjdbrxl9h4cfid4-noto-fonts-extra-2018-11-30' with sha256 hash '0l94aiy1b3qirg2mmbagbr0014vqk32za79pzck1acy2hgy716kq' instead of the expected hash '1lih49bqmsmblczvbl7qb1bhn
0bq8v5xkr991b3gjghpdkx584bc'
cannot build derivation '/nix/store/86vmv8dsi4vrdj6gxzcq64vlb807fgas-env.drv': 1 dependencies couldn't be built
[1 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/86vmv8dsi4vrdj6gxzcq64vlb807fgas-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/51500
1 package failed to build:
noto-fonts-extra

1 package were build:
noto-fonts

@lheckemann
Copy link
Member

This should probably use fetchFromGitHub, which may fix the above hash error.

@colemickens
noto-fonts: update 2017-10-24 -> 2018-11-30
d13f9de 
Signed-off-by: Cole Mickens <cole.mickens@gmail.com>
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build noto-fonts

@worldofpeace
Copy link
Contributor

I don't think lchmod (file attributes) error: Function not implemented is anything to worry about.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 4, 2018

It was there before on aarch664

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 4, 2018

I'm confused about the naming of $out

On aarch64 it ends up being /nix/store/<blah>-noto-fonts-${version}
But on x64-linux it is /nix/store/<blah>-noto-fonts-${rev}

It wont prevent the use of the font but I wonder why Nix has a different behaviour

@worldofpeace worldofpeace merged commit 8b7f33b into NixOS:master Dec 6, 2018
@marsam marsam mentioned this pull request Dec 15, 2018
Closed
@colemickens colemickens deleted the noto branch January 30, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@colemickens @c0bw3b @Mic92 @lheckemann @worldofpeace @infinisil @GrahamcOfBorg