Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Steam runtime refactor backport #51508

Closed
wants to merge 2 commits into from
Closed

Steam runtime refactor backport #51508

wants to merge 2 commits into from

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Dec 4, 2018 •
edited

Motivation for this change

Backport of #49420

Closes #51476

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Synthetica9
steam: refactor steam-runtime
03aada8 
Overview of changes:

- Use JSON instead of Nix for runtime-generated. The fetching of sources
  is done in runtime.nix.
- runtime-generated now only specifies a path within the steamrt mirror,
  instead of the full url.
- Automatically update the version (date) of steam-runtime.
- Add a version to steam-runtime-wrapped.
- Remove runtime-mirror.nix. There was no reference anywhere in nixpkgs.
@Synthetica9
Ran update-runtime.py
fd2ddf5
@Synthetica9 Synthetica9 mentioned this pull request Dec 4, 2018
Closed
@jameysharp
Copy link
Contributor

I've tested the steamRuntimeRefactorBackport branch at fd2ddf5, and it works for me!

@Synthetica9 Synthetica9 mentioned this pull request Dec 10, 2018
Merged
10 tasks
@samueldr
Copy link
Member

Hi 👋, sorry for not getting to this while release-18.09 was still supported.

The silver lining, though, I guess is that the change is now in the current stable?

(triage) closing this PR, as it is a backport for the now unsupported previous stable branch.

I don't think there is (there shouldn't be) any changes that still need to be ported to current stable or unstable, but if there was, I invite you to open a new PR. Thanks for contributing.

@samueldr samueldr closed this Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Synthetica9 @jameysharp @samueldr @GrahamcOfBorg