Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polar-bookshelf: 1.0.13 -> 1.1.0 #51471

Merged
merged 1 commit into from Dec 3, 2018
Merged

polar-bookshelf: 1.0.13 -> 1.1.0 #51471

merged 1 commit into from Dec 3, 2018

Conversation

fx-chun
Copy link
Member

@fx-chun fx-chun commented Dec 3, 2018

Motivation for this change
# 1.0.14

- Upgrade to latest semver and firebase-tools 

- Fixed bug where the lightbox was kept enabled after we deleted an annotation

- We can now capture a new class of documents that use a vertical height on 
  their CSS selectors. 

- We can now capture XML documents which used XSL stylesheets.

- Major refactor of the disk datastore for the pending cloud sync functionality
  we're working on.

# 1.1.0

Polar 1.1 is fresh out the door and a lot of amazing features and bug fixes are enabled in this release.

The biggest feature by far is our support for the 'Save to Polar' chrome extension that allows you to send the URL of your active tab to Polar for content capture.

This makes it a lot easier to work with Polar as you can just click a button in Chrome and have it sent to Polar.

We plan on adding support for Safari, and Firefox in the future but we're taking things one step at a time.

Other features in 1.1 include:
- Disabling amp for now until we have a better solution on how to show the user that an AMP page is displayed and how to disable / enable it. Otherwise its confusing and often the amp page is WORSE not better.
- Fixed bugs with the browser size not changing during capture browser changing and also fixed some issues with it not properly accepting the browser change in some situations.
- Fixed bug in HTML zoom where the page would be truncated improperly.
- Blocked amp ads during the capture but they aren't blocked during the preview at the moment.
- "Fixed" nasty anti-aliasing bug in electron by blocking amp ads. They were annoying anyway but for some reason they were breaking chrome rendering - probably due to some web component nonsense.
- Implemented a new strategy with the vertical height algorithm in the capture system to revert it back to auto instead of a fixed max-height. Works a lot better now.
- Date/times no longer include ' ago' to be a bit more concise.
- Added small FAQ entry to enable Anki sync.
- Fixed a bug where we could select text and not properly work with elements.
- Renderer analytics didn't understand that a callback without an error wasn't a failure.
- Upgraded a number of important react packages: react react-dom react-moment react-select @types/react-table @types/react-select @types/react @types/prop-types @types/node-fetch
- removed inversify package (were not using it)
- latest fontawesome
- latest node-fetch
- fixed issue with electron-builder where it was forcing us to upgrade to the latest version for each release.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 3, 2018

Woah this thing gets updated a lot :)

@GrahamcOfBorg build polar-bookshelf

@c0bw3b c0bw3b merged commit aad3176 into NixOS:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants