fetchurl: fix and add extra KDE mirrors #51480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The gwdg.de mirror has moved the relative path of its KDE tarballs - Add new mirrors from Berkeley and MIT, which are on the list of officially supported mirrors https://download.kde.org/extra/download-mirrors.html
c0bw3b
reviewed
Dec 3, 2018
| @@ -73,7 +73,9 @@ rec { | |||
| # Mirrors of ftp://ftp.kde.org/pub/kde/. | |||
| kde = [ | |||
| "http://download.kde.org/download.php?url=" | |||
There was a problem hiding this comment.
Could we also do
Suggested change
| "http://download.kde.org/download.php?url=" | |
| "https://download.kde.org/download.php?url=" |
Note that it's a redirect anyway:
> http -h http://download.kde.org/download.php
HTTP/1.1 301 Moved Permanently
[...]
Location: https://download.kde.org/download.php
|
Also consider adding one HTTP mirror from Asia for users on this side of the world? |
- The official one is a redirect to HTTPS anyways, so go directly to HTTPS - Add China USTC for Asian users - Swap Finland university from FTP to HTTP
bhipple
commented
Dec 3, 2018
| "http://download.kde.org/download.php?url=" | ||
| http://ftp.gwdg.de/pub/x11/kde/ | ||
| ftp://ftp.heanet.ie/mirrors/ftp.kde.org/ | ||
| ftp://ftp.kde.org/pub/kde/ |
There was a problem hiding this comment.
This one's redundant, since we already have the HTTPS kde.org
bhipple
commented
Dec 3, 2018
| kde = [ | ||
| "http://download.kde.org/download.php?url=" | ||
| http://ftp.gwdg.de/pub/x11/kde/ | ||
| ftp://ftp.heanet.ie/mirrors/ftp.kde.org/ |
There was a problem hiding this comment.
This one does not appear to be online, as far as I can tell; removed
bhipple
commented
Dec 3, 2018
| http://ftp.gwdg.de/pub/x11/kde/ | ||
| ftp://ftp.heanet.ie/mirrors/ftp.kde.org/ | ||
| ftp://ftp.kde.org/pub/kde/ | ||
| ftp://ftp.funet.fi/pub/mirrors/ftp.kde.org/pub/kde/ |
There was a problem hiding this comment.
Swapped to HTTP, which is likely faster, and more likely to make it through firewalls.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://download.kde.org/extra/download-mirrors.html
Motivation for this change
I had some issues downloading KDE source tarballs with the existing mirrors; at least 1 of them is broken, and fixed here. The newly added ones work.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)