Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes: 1.12.2 -> 1.12.3 #51482

Merged
merged 1 commit into from Dec 4, 2018
Merged

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Dec 3, 2018

Motivation for this change

This release contains various bugfixes and changes for the 1.12.X major of Kubernetes. Most importantly though, a fix for CVE-2018-1002105.

See also: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.12.md#changelog-since-v1122

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zimbatm
Copy link
Member

zimbatm commented Dec 4, 2018

@GrahamcOfBorg build kubernetes

@johanot
Copy link
Contributor Author

johanot commented Dec 4, 2018

For the record, ofborg did finish bulding kubernetes. It's just not very verbose about it: https://logs.nix.ci/?key=nixos%2Fnixpkgs.51482

@zimbatm
Copy link
Member

zimbatm commented Dec 4, 2018

looks like it worked. ofborg changed recently and now posts build statuses as checks: https://github.com/NixOS/nixpkgs/pull/51482/checks

@zimbatm zimbatm merged commit 7f06f36 into NixOS:master Dec 4, 2018
@zimbatm
Copy link
Member

zimbatm commented Dec 4, 2018

is it something that also needs to be back-ported to 18.09 ?

@johanot
Copy link
Contributor Author

johanot commented Dec 4, 2018

@zimbatm 18.09 has Kubernetes 1.11.X.. Created separate PR for that: #51486

@johanot johanot deleted the kubernetes-1.12.3 branch December 4, 2018 18:17
globin pushed a commit to mayflower/nixpkgs that referenced this pull request Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants