Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

materia-theme: 20181115 -> 20181125 #51492

Merged
merged 2 commits into from Dec 4, 2018
Merged

materia-theme: 20181115 -> 20181125 #51492

merged 2 commits into from Dec 4, 2018

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Dec 4, 2018

Motivation for this change

Update to version 20181125

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 4, 2018 •
edited

Hello @romildo
Do you think this could live under pkgs/data/themes instead of misc/themes ? And be declared in the ### DATA section of all-packages.nix

I know ATM every other themes are under that top-level misc but it is too generic and it would be logical for themes to live next to icons and fonts and such.

@romildo
Copy link
Contributor Author

romildo commented Dec 4, 2018

Do you think this could live under pkgs/data/themes instead of misc/themes ? And be declared in the ### DATA section of all-packages.nix

I know ATM every others themes are under that top-level misc but it is too generic and it would be logical for themes to live next to icons and fonts and such.

I agree. In general theme files are installed under /share/themes and are data. But there are a few exceptions, which installs also some executable libraries, like the murrine gtk engine.

@romildo
Copy link
Contributor Author

romildo commented Dec 4, 2018

@GrahamcOfBorg build materia-theme

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 4, 2018

Indeed. Something like gtk-engine-murrine (which is mostly a library) should live under pkgs/development/libraries/ then. (or pkgs/desktops/ but less ideal)

@romildo
Copy link
Contributor Author

romildo commented Dec 4, 2018

Do you think this could live under pkgs/data/themes instead of misc/themes ? And be declared in the ### DATA section of all-packages.nix

Done.

c0bw3b
c0bw3b approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@c0bw3b c0bw3b merged commit 911aa08 into NixOS:master Dec 4, 2018
@romildo romildo deleted the upd.materia-theme branch December 4, 2018 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @c0bw3b @GrahamcOfBorg