Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mock to the list of whisper's test inputs. #51485

Merged
merged 1 commit into from Dec 3, 2018
Merged

Add mock to the list of whisper's test inputs. #51485

merged 1 commit into from Dec 3, 2018

Conversation

polynomial
Copy link
Contributor

This was required as the versiof whisper was upgraded from
1.1.3 to 1.1.4 and mock was added as a test dependency in
that release:
graphite-project/whisper@703dd9d#diff-62849af500c571aa4532da7be8833e73R14

Motivation for this change

#51484

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@polynomial
Add mock to the list of whisper's test inputs.
83f782f 
This was required as the versiof whisper was upgraded from
1.1.3 to 1.1.4 and mock was added as a test dependency in
that release:
graphite-project/whisper@703dd9d#diff-62849af500c571aa4532da7be8833e73R14
@Mic92
Copy link
Member

Mic92 commented Dec 3, 2018

@GrahamcOfBorg build python37Packages.whisper python27Packages.whisper

@Mic92 Mic92 merged commit 20f11e6 into NixOS:master Dec 3, 2018
@sergeykranga sergeykranga deleted the whisper_mock branch November 14, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@polynomial @Mic92 @GrahamcOfBorg