Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderdoc: 1.1 -> 1.2 #51472

Merged
merged 1 commit into from Dec 12, 2018
Merged

renderdoc: 1.1 -> 1.2 #51472

merged 1 commit into from Dec 12, 2018

Conversation

Ralith
Copy link
Contributor

@Ralith Ralith commented Dec 3, 2018

Motivation for this change

Routine update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build renderdoc

@worldofpeace
Copy link
Contributor

Looking at the Release Notes i think at least the python extensions need testing.

@Ralith
Copy link
Contributor Author

Ralith commented Dec 6, 2018

That would be welcome, but should it block the update?

@worldofpeace
Copy link
Contributor

IMHO updates should be quality assured if deemed necessary.

@worldofpeace
Copy link
Contributor

As it's been almost a week and no one has volunteered, I think we'll be merging 😄

@worldofpeace worldofpeace merged commit d9eadb4 into NixOS:master Dec 12, 2018
@Ralith Ralith deleted the renderdoc branch December 12, 2018 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ralith @worldofpeace @GrahamcOfBorg