Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applications.audio.luppp: new package (at version 1.2.0) #51473

Closed
wants to merge 1 commit into from
Closed

applications.audio.luppp: new package (at version 1.2.0) #51473

wants to merge 1 commit into from

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Dec 3, 2018 •
edited

Motivation for this change

This packages an interesting audio application called Luppp

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar reviewed Dec 3, 2018
View reviewed changes
pkgs/applications/audio/luppp/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/luppp/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/luppp/default.nix Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Contributor

Merged to master in c26dbef

@worldofpeace
Copy link
Contributor

@prusnak Thanks for this, I've been meaning to package this application 😄

@prusnak prusnak deleted the luppp branch December 6, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prusnak @worldofpeace @jtojnar @GrahamcOfBorg