Skip to content

[18.09] python.pkgs.pygraphviz: add graphviz path #51502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2018
Merged

[18.09] python.pkgs.pygraphviz: add graphviz path #51502

merged 1 commit into from
Dec 4, 2018
+28 −3

Conversation

timokau
Copy link
Member

@timokau timokau commented Dec 4, 2018

Motivation for this change

Backport of #51501, since it fixes a bug.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@timokau
python.pkgs.pygraphviz: add graphviz path

Verified

This commit was signed with the committer’s verified signature.
rasendubi Oleksii Shmalko
GPG key ID: DCEF7BCCEB3066C3
Verified
Learn about vigilant mode
9912660 
(cherry picked from commit 21de751)
@timokau timokau changed the base branch from master to release-18.09 December 4, 2018 10:53
@timokau timokau mentioned this pull request Dec 4, 2018
Merged
10 tasks
@timokau
Copy link
Member Author

timokau commented Dec 4, 2018

@GrahamcOfBorg build python2.pkgs.pygraphviz python3.pkgs.pygraphviz

@GrahamcOfBorg GrahamcOfBorg added 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch and removed 6.topic: emacs Text editor 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: printing 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Dec 4, 2018
@timokau timokau changed the title Pygraphviz path backport [18.09] python.pkgs.pygraphviz: add graphviz path Dec 4, 2018
@timokau
Copy link
Member Author

timokau commented Dec 4, 2018

Sorry for all the requested review, selected the wrong base and githubs code owner system went wild.

@timokau timokau merged commit 8992f52 into NixOS:release-18.09 Dec 4, 2018
@timokau timokau deleted the pygraphviz-path-backport branch December 4, 2018 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg