Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: 6.14.4 -> 6.15.1, 8.12.0 -> 8.14.1 #52511

Merged
merged 2 commits into from Dec 31, 2018
Merged

nodejs: 6.14.4 -> 6.15.1, 8.12.0 -> 8.14.1 #52511

merged 2 commits into from Dec 31, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 19, 2018

Motivation for this change

75b894af0f0 needs to be backported to 18.09 because includes a fix for CVE-2018-12122 https://nodejs.org/en/blog/release/v6.15.1/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil infinisil merged commit ced986c into NixOS:master Dec 31, 2018
@infinisil
Copy link
Member

Pinging @NixOS/backports for 75b894a

@samueldr
Copy link
Member

[release-18.09 5d94e19be99] nodejs-6_x: 6.14.4 -> 6.15.1
Author: Mario Rodas marsam@users.noreply.github.com
Date: Tue Dec 18 20:58:02 2018 -0500
1 file changed, 2 insertions(+), 2 deletions(-)
[release-18.09 2c654718534] nodejs-8_x: 8.11.4 -> 8.12.0
Author: adisbladis adisbladis@gmail.com
Date: Sun Oct 14 13:58:02 2018 +0800
1 file changed, 2 insertions(+), 2 deletions(-)
[release-18.09 f7ba5a13680] nodejs-8_x: 8.12.0 -> 8.14.1
Author: Mario Rodas marsam@users.noreply.github.com
Date: Tue Dec 18 20:57:04 2018 -0500
1 file changed, 2 insertions(+), 2 deletions(-)

Updated nodejs 8.x too with missing commit.

@marsam marsam deleted the update-nodejs branch December 31, 2018 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilligan gilligan gilligan approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marsam @infinisil @samueldr @gilligan @GrahamcOfBorg