Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suitesparse: Fix darwin support #52508

Merged
merged 1 commit into from Dec 31, 2018
Merged

suitesparse: Fix darwin support #52508

merged 1 commit into from Dec 31, 2018

Conversation

tkonolige
Copy link
Contributor

Motivation for this change

Suitesparse libraries would end up containing references to the build
directory. fixDarwinDylibNames appears to not fix this problem. We
manually use intall_name_tool to set the library paths correctly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tkonolige
suitesparse: Fix darwin support
00005ce 
Suitesparse libraries would end up containing references to the build
directory. fixDarwinDylibNames appears to not fix this problem. We
manually use intall_name_tool to set the library paths correctly.
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 19, 2018

cc @ttuegel as maintainer

@ttuegel
Copy link
Member

ttuegel commented Dec 22, 2018

@GrahamcOfBorg build suitesparse

@ttuegel
Copy link
Member

ttuegel commented Dec 22, 2018

Will this need to be backported to the earlier versions of suitesparse in Nixpkgs?

@tkonolige
Copy link
Contributor Author

I don't really know how old versions of packages work in nixpkgs. How can I check if this needs to be backported?

@tkonolige
Copy link
Contributor Author

ping @ttuegel

@infinisil
Copy link
Member

No backport needed, suitesparse builds (on Darwin) on current stable

@infinisil infinisil merged commit eb86439 into NixOS:master Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tkonolige @c0bw3b @ttuegel @infinisil @GrahamcOfBorg @Janik-Haag