Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniflux: 2.0.12 -> 2.0.13 #52517

Closed
wants to merge 1 commit into from
Closed

miniflux: 2.0.12 -> 2.0.13 #52517

wants to merge 1 commit into from

Conversation

nornagon
Copy link
Contributor

Motivation for this change

Adds support for unix socket listening, amongst other things :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Adds support for unix socket listening, amongst other things :)
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 19, 2018

Hello and thanks for the contribution.
Could you rewrite your short commit message to be miniflux: 2.0.12 -> 2.0.13 please?
This format comes from nixpkgs guidelines.

Otherwise, LGTM.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build miniflux

@worldofpeace
Copy link
Contributor

@nornagon You also need to regenerate the deps.nix with https://github.com/adisbladis/vgo2nix

I usually do this like:

  • Clone the Project
  • Checkout to the tag
  • run vgo2nix

Then copy the generated deps.nix into the tree and see if there's a diff.

@nornagon nornagon changed the title Update miniflux to 2.0.13 miniflux: 2.0.12 -> 2.0.13 Dec 19, 2018
@nornagon
Copy link
Contributor Author

this is maybe a dumb question, but how do i run vgo2nix? there doesn't seem to be a derivation for it

@nornagon
Copy link
Contributor Author

(thanks for the help btw!)

@nornagon
Copy link
Contributor Author

oh wait, there is one, just not in 18.09

@nornagon
Copy link
Contributor Author

I ran it and it produced identical output to what's already in the tree:

[

  {
    goPackagePath = "github.com/PuerkitoBio/goquery";
    fetch = {
      type = "git";
      url = "https://github.com/PuerkitoBio/goquery";
      rev = "v1.4.1";
      sha256 = "11010z9ask21r0dskvm2pbh3z8951bnpcqg8aqa213if4h34gaa2";
    };
  }

  {
    goPackagePath = "github.com/andybalholm/cascadia";
    fetch = {
      type = "git";
      url = "https://github.com/andybalholm/cascadia";
      rev = "v1.0.0";
      sha256 = "09j8cavbhqqdxjqrkwbc40g8p0i49zf3184rpjm5p2rjbprcghcc";
    };
  }

  {
    goPackagePath = "github.com/golang/protobuf";
    fetch = {
      type = "git";
      url = "https://github.com/golang/protobuf";
      rev = "v1.1.0";
      sha256 = "0ya4ha7m20bw048m1159ppqzlvda4x0vdprlbk5sdgmy74h3xcdq";
    };
  }

  {
    goPackagePath = "github.com/gorilla/context";
    fetch = {
      type = "git";
      url = "https://github.com/gorilla/context";
      rev = "v1.1.1";
      sha256 = "03p4hn87vcmfih0p9w663qbx9lpsf7i7j3lc7yl7n84la3yz63m4";
    };
  }

  {
    goPackagePath = "github.com/gorilla/mux";
    fetch = {
      type = "git";
      url = "https://github.com/gorilla/mux";
      rev = "v1.6.2";
      sha256 = "0pvzm23hklxysspnz52mih6h1q74vfrdhjfm1l3sa9r8hhqmmld2";
    };
  }

  {
    goPackagePath = "github.com/lib/pq";
    fetch = {
      type = "git";
      url = "https://github.com/lib/pq";
      rev = "v1.0.0";
      sha256 = "1zqnnyczaf00xi6xh53vq758v5bdlf0iz7kf22l02cal4i6px47i";
    };
  }

  {
    goPackagePath = "github.com/tdewolff/minify";
    fetch = {
      type = "git";
      url = "https://github.com/tdewolff/minify";
      rev = "v2.3.5";
      sha256 = "0x67kgjhc6mfzjhr4xmw0j3qapzhkgwwahvv5b44rb449ml2qx5m";
    };
  }

  {
    goPackagePath = "github.com/tdewolff/parse";
    fetch = {
      type = "git";
      url = "https://github.com/tdewolff/parse";
      rev = "v2.3.3";
      sha256 = "190y2jykp8qyp6y58ky1v1fvmaqjnrsr1ksbqrrspf1gpjy69i94";
    };
  }

  {
    goPackagePath = "golang.org/x/crypto";
    fetch = {
      type = "git";
      url = "https://go.googlesource.com/crypto";
      rev = "614d502a4dac";
      sha256 = "1rcyvsl8b8pk7h8lwl0fpiflrx8zs121wi5490ln0qnvkk8d4bwy";
    };
  }

  {
    goPackagePath = "golang.org/x/net";
    fetch = {
      type = "git";
      url = "https://go.googlesource.com/net";
      rev = "8a410e7b638d";
      sha256 = "0hp0l8f6fir5gmgrjq0mhh5ikc0rlrm72774228800kfwqjrxxny";
    };
  }

  {
    goPackagePath = "golang.org/x/oauth2";
    fetch = {
      type = "git";
      url = "https://go.googlesource.com/oauth2";
      rev = "d2e6202438be";
      sha256 = "0wbn75fd10485nb93bm4kqldqifdim5xqy4v7r5sdvimvf3fyhn7";
    };
  }

  {
    goPackagePath = "golang.org/x/sync";
    fetch = {
      type = "git";
      url = "https://go.googlesource.com/sync";
      rev = "1d60e4601c6f";
      sha256 = "046jlanz2lkxq1r57x9bl6s4cvfqaic6p2xybsj8mq1120jv4rs6";
    };
  }

  {
    goPackagePath = "golang.org/x/sys";
    fetch = {
      type = "git";
      url = "https://go.googlesource.com/sys";
      rev = "4910a1d54f87";
      sha256 = "0p2pp6mny34gjcvylx3ddzdaxn7hv008hppsr11w1bvyzj7s27by";
    };
  }

  {
    goPackagePath = "golang.org/x/text";
    fetch = {
      type = "git";
      url = "https://go.googlesource.com/text";
      rev = "v0.3.0";
      sha256 = "0r6x6zjzhr8ksqlpiwm5gdd7s209kwk5p4lw54xjvz10cs3qlq19";
    };
  }

  {
    goPackagePath = "google.golang.org/appengine";
    fetch = {
      type = "git";
      url = "https://github.com/golang/appengine";
      rev = "v1.1.0";
      sha256 = "1pz202zszg8f35dk5pfhwgcdi3r6dx1l4yk6x6ly7nb4j45zi96x";
    };
  }
]

@worldofpeace
Copy link
Contributor

Merged in 3b17e17
Just had to change the commit msg 😄

@nornagon Thanks ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants