Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: 1.30.0 -> 1.30.1 #52503

Merged
merged 1 commit into from Dec 19, 2018
Merged

vscode: 1.30.0 -> 1.30.1 #52503

merged 1 commit into from Dec 19, 2018

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Dec 19, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified all the hashes and executed this successfully on NixOS 👍

@worldofpeace worldofpeace merged commit 0c06fae into NixOS:master Dec 19, 2018
@worldofpeace
Copy link
Contributor

@eadwu
Would you mind preparing a backport pr of all your changes to vscode and extensions like #52043?

We'd like to keep this in sync on 18.09.

@eadwu
Copy link
Member Author

eadwu commented Dec 19, 2018

Separate or squash into one PR?

@worldofpeace
Copy link
Contributor

Separate or squash into one PR?

One pr with all the commits cherry-picked should be good.

If you're not familiar see https://nixos.org/nixpkgs/manual/#submitting-changes-stable-release-branches
Adding a reason to the commit message shouldn't be needed btw

@eadwu eadwu mentioned this pull request Dec 19, 2018
Merged
10 tasks
@eadwu eadwu deleted the vscode/1.30.1 branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @worldofpeace @GrahamcOfBorg