Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql: disable parallel building on Darwin #51142

Merged
merged 1 commit into from Nov 28, 2018
Merged

postgresql: disable parallel building on Darwin #51142

merged 1 commit into from Nov 28, 2018

Conversation

alyssais
Copy link
Member

Motivation for this change

There have been multiple reports of this failing. I don't know if the other one linked in the issue was on Darwin or not, but no point disabling on Linux if we don't have any confirmed reports of failure.

Fixes #51093.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
postgresql: disable parallel building on Darwin
c41c195 
There have been multiple reports of this failing.

Fixes NixOS#51093.
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: postgresql

Partial log (click to expand)

checking for references to /build in /nix/store/k31n4pnq128dy17s2r920cnhxkf0k5h3-postgresql-9.6.10-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/apa12026lv7awimp6bikscdhs8v5lxi9-postgresql-9.6.10-doc
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/apa12026lv7awimp6bikscdhs8v5lxi9-postgresql-9.6.10-doc
checking for references to /build in /nix/store/apa12026lv7awimp6bikscdhs8v5lxi9-postgresql-9.6.10-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/kq16v1n6kz6gv8fs8zvg6kxizzsndmfp-postgresql-9.6.10-man
gzipping man pages under /nix/store/kq16v1n6kz6gv8fs8zvg6kxizzsndmfp-postgresql-9.6.10-man/share/man/
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/kq16v1n6kz6gv8fs8zvg6kxizzsndmfp-postgresql-9.6.10-man
checking for references to /build in /nix/store/kq16v1n6kz6gv8fs8zvg6kxizzsndmfp-postgresql-9.6.10-man...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: postgresql

Partial log (click to expand)

checking for references to /build in /nix/store/ns72q9ms8xl5ziqn26v3yafv9y7pyv0l-postgresql-9.6.10-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/8xrs0ip6p0xasqaqszhkr2nw18iw8ixf-postgresql-9.6.10-doc
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/8xrs0ip6p0xasqaqszhkr2nw18iw8ixf-postgresql-9.6.10-doc
checking for references to /build in /nix/store/8xrs0ip6p0xasqaqszhkr2nw18iw8ixf-postgresql-9.6.10-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/prnx1lc8cbksff31c4i4ygzkkqx2qppx-postgresql-9.6.10-man
gzipping man pages under /nix/store/prnx1lc8cbksff31c4i4ygzkkqx2qppx-postgresql-9.6.10-man/share/man/
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/prnx1lc8cbksff31c4i4ygzkkqx2qppx-postgresql-9.6.10-man
checking for references to /build in /nix/store/prnx1lc8cbksff31c4i4ygzkkqx2qppx-postgresql-9.6.10-man...

@Mic92 Mic92 merged commit c1ba7f4 into NixOS:master Nov 28, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 28, 2018

Any backport required here?

@Mic92
Copy link
Member

Mic92 commented Nov 28, 2018

@GrahamcOfBorg build postgresql

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: postgresql

Partial log (click to expand)

/nix/store/xanfzq58jwyx0bvkwmykvvnk5cclj8j1-postgresql-9.6.10

@Mic92
Copy link
Member

Mic92 commented Nov 28, 2018

If it turns out to have a different root cause, according to #51093 (comment)
I can enable it again.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: postgresql

Partial log (click to expand)

these paths will be fetched (4.79 MiB download, 22.07 MiB unpacked):
  /nix/store/i6q4z7hsn6gvr8igqcyjdc3yibk1pif2-postgresql-9.6.10
  /nix/store/ns72q9ms8xl5ziqn26v3yafv9y7pyv0l-postgresql-9.6.10-lib
copying path '/nix/store/ns72q9ms8xl5ziqn26v3yafv9y7pyv0l-postgresql-9.6.10-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/i6q4z7hsn6gvr8igqcyjdc3yibk1pif2-postgresql-9.6.10' from 'https://cache.nixos.org'...
/nix/store/i6q4z7hsn6gvr8igqcyjdc3yibk1pif2-postgresql-9.6.10

@alyssais
Copy link
Member Author

Any backport required here?

I'm not sure, since I'm not even entirely convinced that this is going to solve the issue.

@alyssais alyssais deleted the postgres_parallel branch November 28, 2018 00:38
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: postgresql

Partial log (click to expand)

/nix/store/8r3dksphwlkikhvxsmmkmsv6xmp56n08-postgresql-9.6.10/lib/pgxs/config/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/sv35yjk452mggg76bz94nppibj96a66h-bash-4.4-p23/bin/sh"
/nix/store/8r3dksphwlkikhvxsmmkmsv6xmp56n08-postgresql-9.6.10/lib/pgxs/config/missing: interpreter directive changed from " /bin/sh" to "/nix/store/sv35yjk452mggg76bz94nppibj96a66h-bash-4.4-p23/bin/sh"
strip is /nix/store/mvpvjar6m4jpjcz48715w2pax53djv6g-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/lnschwdri2br3s18hp8xinvwwbc5zwc8-postgresql-9.6.10-lib/lib
patching script interpreter paths in /nix/store/lnschwdri2br3s18hp8xinvwwbc5zwc8-postgresql-9.6.10-lib
strip is /nix/store/mvpvjar6m4jpjcz48715w2pax53djv6g-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/1c9kmqz39pqm9vsfppg7j6db2cvsyr9x-postgresql-9.6.10-doc
gzipping man pages under /nix/store/rsly1m8w2c9ysf5xxy184lmzhp4d0zms-postgresql-9.6.10-man/share/man/
strip is /nix/store/mvpvjar6m4jpjcz48715w2pax53djv6g-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/rsly1m8w2c9ysf5xxy184lmzhp4d0zms-postgresql-9.6.10-man

@Mic92
Copy link
Member

Mic92 commented Nov 28, 2018

At least ofborg seems to agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice thoughtpolice is a code owner

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alyssais @GrahamcOfBorg @Mic92