Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conky: init latest #51147

Closed
wants to merge 1 commit into from
Closed

conky: init latest #51147

wants to merge 1 commit into from
+145 −0

Conversation

lovek323
Copy link
Member

Motivation for this change

I am not sure why conky haven't released a new version, but this issue was fixed in April: brndnmtthws/conky#471 (with this commit: brndnmtthws/conky@8790281)

I use docker and conky and without this fix it's broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I'm not sure where to place things like this or if there's a better way to create a new derivation that only changes the version and the hash. Any advice appreciated.

Sorry, something went wrong.

@lovek323 lovek323 added the 8.has: package (update) This PR updates a package to a newer version label Nov 27, 2018
@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 27, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: conky

Partial log (click to expand)

shrinking /nix/store/mj42g7h09qlc9qv6vhadbkv5rj4pd325-conky-1.10.8/bin/conky
shrinking /nix/store/mj42g7h09qlc9qv6vhadbkv5rj4pd325-conky-1.10.8/lib/conky/libcairo_imlib2_helper.so
shrinking /nix/store/mj42g7h09qlc9qv6vhadbkv5rj4pd325-conky-1.10.8/lib/conky/libcairo.so
shrinking /nix/store/mj42g7h09qlc9qv6vhadbkv5rj4pd325-conky-1.10.8/lib/conky/libimlib2.so
gzipping man pages under /nix/store/mj42g7h09qlc9qv6vhadbkv5rj4pd325-conky-1.10.8/share/man/
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mj42g7h09qlc9qv6vhadbkv5rj4pd325-conky-1.10.8/lib  /nix/store/mj42g7h09qlc9qv6vhadbkv5rj4pd325-conky-1.10.8/bin
patching script interpreter paths in /nix/store/mj42g7h09qlc9qv6vhadbkv5rj4pd325-conky-1.10.8
checking for references to /build in /nix/store/mj42g7h09qlc9qv6vhadbkv5rj4pd325-conky-1.10.8...
/nix/store/mj42g7h09qlc9qv6vhadbkv5rj4pd325-conky-1.10.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: conky

Partial log (click to expand)

shrinking /nix/store/1iah1g57nmd8x1snvib8fnpvj3kd6kpg-conky-1.10.8/bin/conky
shrinking /nix/store/1iah1g57nmd8x1snvib8fnpvj3kd6kpg-conky-1.10.8/lib/conky/libcairo_imlib2_helper.so
shrinking /nix/store/1iah1g57nmd8x1snvib8fnpvj3kd6kpg-conky-1.10.8/lib/conky/libimlib2.so
shrinking /nix/store/1iah1g57nmd8x1snvib8fnpvj3kd6kpg-conky-1.10.8/lib/conky/libcairo.so
gzipping man pages under /nix/store/1iah1g57nmd8x1snvib8fnpvj3kd6kpg-conky-1.10.8/share/man/
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1iah1g57nmd8x1snvib8fnpvj3kd6kpg-conky-1.10.8/lib  /nix/store/1iah1g57nmd8x1snvib8fnpvj3kd6kpg-conky-1.10.8/bin
patching script interpreter paths in /nix/store/1iah1g57nmd8x1snvib8fnpvj3kd6kpg-conky-1.10.8
checking for references to /build in /nix/store/1iah1g57nmd8x1snvib8fnpvj3kd6kpg-conky-1.10.8...
/nix/store/1iah1g57nmd8x1snvib8fnpvj3kd6kpg-conky-1.10.8

@erikarvstedt
Copy link
Member

There's no need to duplicate the whole package definition. conky/latest.nix can be written like so:

{ conky, fetchFromGitHub }:
                                                                                                                                                          
conky.overrideAttrs (_: rec {
  name = "conky-${version}";
  version = "f8ff46c";
                                                                                                                                                        
  src = fetchFromGitHub {
    owner = "brndnmtthws";
    repo = "conky";
    rev = "f8ff46c2dca4d639c9287790c35999bbaae56010";
    sha256 = "0k926axqm1f7pm676lz12ibmcf6c2haiz90sxqsgcp0lb1p58jz1";
  };
});

@worldofpeace
Copy link
Contributor

worldofpeace commented Nov 27, 2018 •
edited
Loading

Also the version of this package should be in the format unstable-YYYY-MM-DD with that date being from the commit.

https://nixos.org/nixpkgs/manual/#sec-package-naming

Also are we sure we can just override the default conky?
Lots of things have changed in the 118 commits since the last release.

@lovek323
Copy link
Member Author

lovek323 commented Nov 27, 2018 •
edited
Loading

Also are we sure we can just need to override the default conky?
Lots of things have changed in the 118 commits since the last release.

@worldofpeace, Are you suggesting that I just replace the default with the latest master? I've been using this version of conky for a few hours now and it is working fine for me, so I'm happy to do that.

@worldofpeace
Copy link
Contributor

Also are we sure we can just need to override the default conky?
Lots of things have changed in the 118 commits since the last release.

@worldofpeace, Are you suggesting that I just replace the default with the latest master? I've been using this version of conky for a few hours now and it is working fine for me, so I'm happy to do that.

Ahh let me rephrase that.

I was suggesting that they could have added more build options, for example, that we need to make configurable. Also it appears that darwin support is in the works.
So it's not a straightforward update where we can just override the src.

And that brndnmtthws/conky@v1.10.8...master could be helpful to you, so you can decide what's needed.

@Mic92
Copy link
Member

Mic92 commented Nov 28, 2018

Can you try to pull the patches in question into our conky instead of adding a new package?

@Mic92 Mic92 mentioned this pull request Nov 28, 2018
Closed
@Mic92
Copy link
Member

Mic92 commented Nov 28, 2018

Also opened: brndnmtthws/conky#684

@lovek323
Copy link
Member Author

Can you try to pull the patches in question into our conky instead of adding a new package?

@Mic92: Yep, I could pull just that fix in. That might be easiest.

@Mic92
Copy link
Member

Mic92 commented Nov 28, 2018

You can ping the conky maintainer in a bit instead of adding an unstable version of this package.

@lovek323
Copy link
Member Author

Closing awaiting a new conky release.

@lovek323 lovek323 closed this Nov 28, 2018
@lovek323 lovek323 deleted the conky-latest branch November 28, 2018 21:42
@lovek323 lovek323 restored the conky-latest branch November 28, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lovek323 @GrahamcOfBorg @erikarvstedt @worldofpeace @Mic92