Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aminal: init at 0.7.4 #51163

Merged
merged 1 commit into from Nov 28, 2018
Merged

aminal: init at 0.7.4 #51163

merged 1 commit into from Nov 28, 2018

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Nov 28, 2018 •
edited

Motivation for this change

Nice terminal emulator.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg build aminal

@kalbasit kalbasit force-pushed the nixpkgs_add-animal branch 2 times, most recently from 208bf5a to fd7a02a Compare November 28, 2018 05:03
@kalbasit
Copy link
Member Author

@GrahamcOfBorg build aminal

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: aminal

Partial log (click to expand)

In file included from ./glfw/src/internal.h:165:
./glfw/src/cocoa_platform.h:34:9: fatal error: 'Carbon/Carbon.h' file not found
#import <Carbon/Carbon.h>
        ^~~~~~~~~~~~~~~~~
1 error generated.
# github.com/liamg/aminal/vendor/github.com/go-gl/gl/all-core/gl
ld: framework not found OpenGL
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
builder for '/nix/store/n3ry4q8wd1pyxjy2s2xfljsxj36g10ll-aminal-0.7.4.drv' failed with exit code 5
error: build of '/nix/store/n3ry4q8wd1pyxjy2s2xfljsxj36g10ll-aminal-0.7.4.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: aminal

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/s40zyjz35zi4jjswh3mld6l1gq7y2g4s-aminal-0.7.4-bin
shrinking /nix/store/s40zyjz35zi4jjswh3mld6l1gq7y2g4s-aminal-0.7.4-bin/bin/aminal
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s40zyjz35zi4jjswh3mld6l1gq7y2g4s-aminal-0.7.4-bin/bin
patching script interpreter paths in /nix/store/s40zyjz35zi4jjswh3mld6l1gq7y2g4s-aminal-0.7.4-bin
checking for references to /build in /nix/store/s40zyjz35zi4jjswh3mld6l1gq7y2g4s-aminal-0.7.4-bin...
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
/nix/store/s40zyjz35zi4jjswh3mld6l1gq7y2g4s-aminal-0.7.4-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: aminal

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/j13ldjm5fi8vliawpi7q2443s73r5li0-aminal-0.7.4-bin
shrinking /nix/store/j13ldjm5fi8vliawpi7q2443s73r5li0-aminal-0.7.4-bin/bin/aminal
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j13ldjm5fi8vliawpi7q2443s73r5li0-aminal-0.7.4-bin/bin
patching script interpreter paths in /nix/store/j13ldjm5fi8vliawpi7q2443s73r5li0-aminal-0.7.4-bin
checking for references to /build in /nix/store/j13ldjm5fi8vliawpi7q2443s73r5li0-aminal-0.7.4-bin...
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
/nix/store/j13ldjm5fi8vliawpi7q2443s73r5li0-aminal-0.7.4-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: aminal

Partial log (click to expand)

/nix/store/j13ldjm5fi8vliawpi7q2443s73r5li0-aminal-0.7.4-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: aminal

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/s40zyjz35zi4jjswh3mld6l1gq7y2g4s-aminal-0.7.4-bin
shrinking /nix/store/s40zyjz35zi4jjswh3mld6l1gq7y2g4s-aminal-0.7.4-bin/bin/aminal
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s40zyjz35zi4jjswh3mld6l1gq7y2g4s-aminal-0.7.4-bin/bin
patching script interpreter paths in /nix/store/s40zyjz35zi4jjswh3mld6l1gq7y2g4s-aminal-0.7.4-bin
checking for references to /build in /nix/store/s40zyjz35zi4jjswh3mld6l1gq7y2g4s-aminal-0.7.4-bin...
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
/nix/store/s40zyjz35zi4jjswh3mld6l1gq7y2g4s-aminal-0.7.4-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: aminal

Partial log (click to expand)

find: '/nix/store/4a6vr5kvpy11jpnifcd50663kai2i3ym-aminal-0.7.4': No such file or directory
find: '/nix/store/4a6vr5kvpy11jpnifcd50663kai2i3ym-aminal-0.7.4': No such file or directory
find: '/nix/store/4a6vr5kvpy11jpnifcd50663kai2i3ym-aminal-0.7.4': No such file or directory
find: '/nix/store/4a6vr5kvpy11jpnifcd50663kai2i3ym-aminal-0.7.4': No such file or directory
find: '/nix/store/4a6vr5kvpy11jpnifcd50663kai2i3ym-aminal-0.7.4': No such file or directory
find: '/nix/store/4a6vr5kvpy11jpnifcd50663kai2i3ym-aminal-0.7.4': No such file or directory
find: '/nix/store/4a6vr5kvpy11jpnifcd50663kai2i3ym-aminal-0.7.4': No such file or directory
find: '/nix/store/4a6vr5kvpy11jpnifcd50663kai2i3ym-aminal-0.7.4': No such file or directory
find: '/nix/store/4a6vr5kvpy11jpnifcd50663kai2i3ym-aminal-0.7.4': No such file or directory
find: '/nix/store/4a6vr5kvpy11jpnifcd50663kai2i3ym-aminal-0.7.4': No such file or directory

@kalbasit
Copy link
Member Author

@NixOS/darwin-maintainers can I get a review on this PR, my first involving Darwin-specific code.

LnL7
LnL7 reviewed Nov 28, 2018
View reviewed changes
pkgs/applications/misc/aminal/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/aminal/default.nix Outdated Show resolved Hide resolved
@kalbasit
Copy link
Member Author

@LnL7 PTAL.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: aminal

Partial log (click to expand)

find: '/nix/store/19wn33h0h63n2qiwhpdpx4m9pfv4wj57-aminal-0.7.4': No such file or directory
find: '/nix/store/19wn33h0h63n2qiwhpdpx4m9pfv4wj57-aminal-0.7.4': No such file or directory
find: '/nix/store/19wn33h0h63n2qiwhpdpx4m9pfv4wj57-aminal-0.7.4': No such file or directory
find: '/nix/store/19wn33h0h63n2qiwhpdpx4m9pfv4wj57-aminal-0.7.4': No such file or directory
find: '/nix/store/19wn33h0h63n2qiwhpdpx4m9pfv4wj57-aminal-0.7.4': No such file or directory
find: '/nix/store/19wn33h0h63n2qiwhpdpx4m9pfv4wj57-aminal-0.7.4': No such file or directory
find: '/nix/store/19wn33h0h63n2qiwhpdpx4m9pfv4wj57-aminal-0.7.4': No such file or directory
find: '/nix/store/19wn33h0h63n2qiwhpdpx4m9pfv4wj57-aminal-0.7.4': No such file or directory
find: '/nix/store/19wn33h0h63n2qiwhpdpx4m9pfv4wj57-aminal-0.7.4': No such file or directory
find: '/nix/store/19wn33h0h63n2qiwhpdpx4m9pfv4wj57-aminal-0.7.4': No such file or directory

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: aminal

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8zslpb5gzmhiwnymqi2f7nxv73dzv9qp-aminal-0.7.4-bin
shrinking /nix/store/8zslpb5gzmhiwnymqi2f7nxv73dzv9qp-aminal-0.7.4-bin/bin/aminal
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8zslpb5gzmhiwnymqi2f7nxv73dzv9qp-aminal-0.7.4-bin/bin
patching script interpreter paths in /nix/store/8zslpb5gzmhiwnymqi2f7nxv73dzv9qp-aminal-0.7.4-bin
checking for references to /build in /nix/store/8zslpb5gzmhiwnymqi2f7nxv73dzv9qp-aminal-0.7.4-bin...
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
/nix/store/8zslpb5gzmhiwnymqi2f7nxv73dzv9qp-aminal-0.7.4-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: aminal

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/349pgr8yn3m1ihrwjlqlw4avkw3acrb0-aminal-0.7.4-bin
shrinking /nix/store/349pgr8yn3m1ihrwjlqlw4avkw3acrb0-aminal-0.7.4-bin/bin/aminal
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/349pgr8yn3m1ihrwjlqlw4avkw3acrb0-aminal-0.7.4-bin/bin
patching script interpreter paths in /nix/store/349pgr8yn3m1ihrwjlqlw4avkw3acrb0-aminal-0.7.4-bin
checking for references to /build in /nix/store/349pgr8yn3m1ihrwjlqlw4avkw3acrb0-aminal-0.7.4-bin...
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
/nix/store/349pgr8yn3m1ihrwjlqlw4avkw3acrb0-aminal-0.7.4-bin

@LnL7 LnL7 merged commit 5c26dc3 into NixOS:master Nov 28, 2018
@kalbasit kalbasit deleted the nixpkgs_add-animal branch November 28, 2018 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalbasit @GrahamcOfBorg @LnL7