Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkpasswd: fix cross compilation #51118

Merged
merged 1 commit into from Nov 28, 2018
Merged

mkpasswd: fix cross compilation #51118

merged 1 commit into from Nov 28, 2018

Conversation

bennofs
Copy link
Contributor

@bennofs bennofs commented Nov 27, 2018

Motivation for this change

Fixes #51112

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bennofs bennofs added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Nov 27, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mkpasswd

Partial log (click to expand)

install -m 0644 mkpasswd.1 /nix/store/gxv22g020ndlif6l0h3zhvw0kjs7dj99-mkpasswd-5.4.0/share/man/man1/
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gxv22g020ndlif6l0h3zhvw0kjs7dj99-mkpasswd-5.4.0
shrinking /nix/store/gxv22g020ndlif6l0h3zhvw0kjs7dj99-mkpasswd-5.4.0/bin/mkpasswd
gzipping man pages under /nix/store/gxv22g020ndlif6l0h3zhvw0kjs7dj99-mkpasswd-5.4.0/share/man/
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gxv22g020ndlif6l0h3zhvw0kjs7dj99-mkpasswd-5.4.0/bin
patching script interpreter paths in /nix/store/gxv22g020ndlif6l0h3zhvw0kjs7dj99-mkpasswd-5.4.0
checking for references to /build in /nix/store/gxv22g020ndlif6l0h3zhvw0kjs7dj99-mkpasswd-5.4.0...
/nix/store/gxv22g020ndlif6l0h3zhvw0kjs7dj99-mkpasswd-5.4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mkpasswd

Partial log (click to expand)

install -m 0644 mkpasswd.1 /nix/store/1pm17lap0avy8fysv1sf6lpn1c4d4fwl-mkpasswd-5.4.0/share/man/man1/
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1pm17lap0avy8fysv1sf6lpn1c4d4fwl-mkpasswd-5.4.0
shrinking /nix/store/1pm17lap0avy8fysv1sf6lpn1c4d4fwl-mkpasswd-5.4.0/bin/mkpasswd
gzipping man pages under /nix/store/1pm17lap0avy8fysv1sf6lpn1c4d4fwl-mkpasswd-5.4.0/share/man/
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1pm17lap0avy8fysv1sf6lpn1c4d4fwl-mkpasswd-5.4.0/bin
patching script interpreter paths in /nix/store/1pm17lap0avy8fysv1sf6lpn1c4d4fwl-mkpasswd-5.4.0
checking for references to /build in /nix/store/1pm17lap0avy8fysv1sf6lpn1c4d4fwl-mkpasswd-5.4.0...
/nix/store/1pm17lap0avy8fysv1sf6lpn1c4d4fwl-mkpasswd-5.4.0

@matthewbauer matthewbauer merged commit c315b9e into NixOS:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bennofs @GrahamcOfBorg @matthewbauer