Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Ghc 8.4.4 default 18.09 #51156

Merged
merged 1 commit into from Nov 28, 2018
Merged

Backport: Ghc 8.4.4 default 18.09 #51156

merged 1 commit into from Nov 28, 2018

Conversation

ElvishJerricco
Copy link
Contributor

Motivation for this change

Backporting the minor update to GHC 8.4.4 as the default to 18.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

basvandijk
basvandijk approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@basvandijk basvandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 8.4.4 fixes several serious bugs in 8.4.3 I think it's important to make it the default.

@Ekleog
Copy link
Member

Ekleog commented Nov 28, 2018

Sanity-test:

@GrahamcOfBorg build haskellPackages.hnix

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.hnix

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: haskellPackages.hnix

Partial log (click to expand)

/nix/store/p64x58ab375g9gymv8fw1vm8a1xy6hmg-hnix-0.5.2/lib/ghc-8.4.4/x86_64-osx-ghc-8.4.4/libHShnix-0.5.2-64MPb9SQ9btHKJyhN5cCCB-ghc8.4.4.dylib: fixing dylib
/nix/store/p64x58ab375g9gymv8fw1vm8a1xy6hmg-hnix-0.5.2/lib/ghc-8.4.4/x86_64-osx-ghc-8.4.4/libHShnix-0.5.2-64MPb9SQ9btHKJyhN5cCCB-ghc8.4.4.dylib: fixing dylib
/nix/store/p64x58ab375g9gymv8fw1vm8a1xy6hmg-hnix-0.5.2/lib/ghc-8.4.4/x86_64-osx-ghc-8.4.4/libHShnix-0.5.2-64MPb9SQ9btHKJyhN5cCCB-ghc8.4.4.dylib: fixing dylib
/nix/store/p64x58ab375g9gymv8fw1vm8a1xy6hmg-hnix-0.5.2/lib/ghc-8.4.4/x86_64-osx-ghc-8.4.4/libHShnix-0.5.2-64MPb9SQ9btHKJyhN5cCCB-ghc8.4.4.dylib: fixing dylib
/nix/store/p64x58ab375g9gymv8fw1vm8a1xy6hmg-hnix-0.5.2/lib/ghc-8.4.4/x86_64-osx-ghc-8.4.4/libHShnix-0.5.2-64MPb9SQ9btHKJyhN5cCCB-ghc8.4.4.dylib: fixing dylib
/nix/store/p64x58ab375g9gymv8fw1vm8a1xy6hmg-hnix-0.5.2/lib/ghc-8.4.4/x86_64-osx-ghc-8.4.4/libHShnix-0.5.2-64MPb9SQ9btHKJyhN5cCCB-ghc8.4.4.dylib: fixing dylib
/nix/store/p64x58ab375g9gymv8fw1vm8a1xy6hmg-hnix-0.5.2/lib/ghc-8.4.4/x86_64-osx-ghc-8.4.4/libHShnix-0.5.2-64MPb9SQ9btHKJyhN5cCCB-ghc8.4.4.dylib: fixing dylib
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/ya2qsf1x02sbkrrfhc2sbn4swaqs6k7y-hnix-0.5.2-doc
/nix/store/p64x58ab375g9gymv8fw1vm8a1xy6hmg-hnix-0.5.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskellPackages.hnix

Partial log (click to expand)

strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4ifvb61fh8wdgrfjnwi7c7clmsld570i-hnix-0.5.2/lib  /nix/store/4ifvb61fh8wdgrfjnwi7c7clmsld570i-hnix-0.5.2/bin
patching script interpreter paths in /nix/store/4ifvb61fh8wdgrfjnwi7c7clmsld570i-hnix-0.5.2
checking for references to /build in /nix/store/4ifvb61fh8wdgrfjnwi7c7clmsld570i-hnix-0.5.2...
wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/3m1sba7y3asvrbn81dmbk13qa9jdbqcq-hnix-0.5.2-doc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/3m1sba7y3asvrbn81dmbk13qa9jdbqcq-hnix-0.5.2-doc
checking for references to /build in /nix/store/3m1sba7y3asvrbn81dmbk13qa9jdbqcq-hnix-0.5.2-doc...
/nix/store/4ifvb61fh8wdgrfjnwi7c7clmsld570i-hnix-0.5.2

@Ekleog Ekleog merged commit 1afc9c9 into NixOS:release-18.09 Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk basvandijk approved these changes

@peti peti Awaiting requested review from peti peti is a code owner

@ryantm ryantm Awaiting requested review from ryantm ryantm is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ElvishJerricco @Ekleog @GrahamcOfBorg @basvandijk @peti