Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql: Remove static libs using host platform extension #51155

Merged
merged 1 commit into from Nov 28, 2018
Merged

postgresql: Remove static libs using host platform extension #51155

merged 1 commit into from Nov 28, 2018

Conversation

endgame
Copy link
Contributor

@endgame endgame commented Nov 28, 2018

Motivation for this change

Closes #50902. See LnL7's comment to understand what's going on.

This allows haskellPackages.postgresql-libpq to build on macOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@endgame
Copy link
Contributor Author

endgame commented Nov 28, 2018

Wow, that's a big rebuild number. I'll rebase this against staging.

@endgame endgame changed the base branch from master to staging November 28, 2018 02:24
@endgame
Copy link
Contributor Author

endgame commented Nov 28, 2018

Rebased to staging.

@Mic92
Copy link
Member

Mic92 commented Nov 28, 2018

@GrahamcOfBorg build postgresql

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: postgresql

Partial log (click to expand)

checking for references to /build/ in /nix/store/67rbmg39m5xpwqg38mvm59fff4nxhf64-postgresql-9.6.11-lib...
shrinking RPATHs of ELF executables and libraries in /nix/store/2rvjbm5rwrykhczypwq8gizq1dvhl6ra-postgresql-9.6.11-doc
strip is /nix/store/6yjvaipy9zffribmc4l13c7i8k19ama5-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2rvjbm5rwrykhczypwq8gizq1dvhl6ra-postgresql-9.6.11-doc
checking for references to /build/ in /nix/store/2rvjbm5rwrykhczypwq8gizq1dvhl6ra-postgresql-9.6.11-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/cwmwr0mqd76c8rch1b1aqfjnailbcm11-postgresql-9.6.11-man
gzipping man pages under /nix/store/cwmwr0mqd76c8rch1b1aqfjnailbcm11-postgresql-9.6.11-man/share/man/
strip is /nix/store/6yjvaipy9zffribmc4l13c7i8k19ama5-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/cwmwr0mqd76c8rch1b1aqfjnailbcm11-postgresql-9.6.11-man
checking for references to /build/ in /nix/store/cwmwr0mqd76c8rch1b1aqfjnailbcm11-postgresql-9.6.11-man...

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: postgresql

Partial log (click to expand)

cannot build derivation '/nix/store/hd3gk8z8acz3s5p1jyrdywsw51hj24vn-hook.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/mp7wqryxzsylipwglqb3yshkcwx3sk0l-flex-2.6.4.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/2my1js8z6bygcl8gismvax62mdicv8vl-bootstrap_cmds-dev-tools-7.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/4sfz6lg8j1af1yli1lmwq7hvdi9db2fx-xnu-osx-10.11.6.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/vjk6b3nllciac6901sp4jx78xr2cdw2v-IOKit-osx-10.11.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/qym2i90pv3cilb41z0w6hzz6xn2kfyfq-configd-osx-10.8.5.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/ffwgnx8qxa3jd44arm0kmb0avpc1d82f-python-2.7.15.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/8lic1cab790dkpbyjvn3p0j8jndysrnr-libxml2-2.9.8.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/4rf6q1l27755mcrqjs4hrzn3cvwh57rs-postgresql-9.6.11.drv': 7 dependencies couldn't be built
error: build of '/nix/store/4rf6q1l27755mcrqjs4hrzn3cvwh57rs-postgresql-9.6.11.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: postgresql

Partial log (click to expand)

cannot build derivation '/nix/store/5q080wfp1cnrskmysa781z4yg7clq6dn-sqlite-3.25.3.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/47ix7k3df056gy3zkg36gyvhqp04hfhv-tzdata-2018e.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/9i511b2sfk1xzmh7ns9fszp95dq25v8w-hook.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/9s0p7d467n96n3pm821a607glyr7a27m-ncurses-6.1-20181027.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/bhk6vzw9f73ss6q7f8fj87indlqq44p6-openssl-1.0.2q.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/q56cz2vdpk2ixbnsq5a071ccaxgi28js-readline-6.3p08.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/vjzvg856fw71ij0r0g8hqn512za74vag-python-2.7.15.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/d0l2zahr99nczia73bn8kaf934yljvw2-libxml2-2.9.8.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/yzrn7yr8npclh551drpp97lw2ki5rpvz-postgresql-9.6.11.drv': 9 dependencies couldn't be built
error: build of '/nix/store/yzrn7yr8npclh551drpp97lw2ki5rpvz-postgresql-9.6.11.drv' failed

Ericson2314
Ericson2314 approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this being used!

thoughtpolice
thoughtpolice approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@thoughtpolice thoughtpolice merged commit 5987c5c into NixOS:staging Nov 28, 2018
@endgame endgame deleted the haskell-postgres-libpq branch November 28, 2018 21:40
@endgame endgame mentioned this pull request Jan 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@FRidh FRidh Awaiting requested review from FRidh

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92

@nbp nbp Awaiting requested review from nbp

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@endgame @Mic92 @GrahamcOfBorg @thoughtpolice @matthewbauer @Ericson2314