Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jfsutils: fix cross compilation #51145

Closed
wants to merge 1 commit into from
Closed

jfsutils: fix cross compilation #51145

wants to merge 1 commit into from

Conversation

eburimu
Copy link
Contributor

@eburimu eburimu commented Nov 27, 2018

Motivation for this change

Fixes #51126

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title fix jfsutils cross compilation jfsutils: fix cross compilation Nov 27, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 27, 2018

@GrahamcOfBorg build jfsutils

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: jfsutils

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: jfsutils

Partial log (click to expand)

shrinking /nix/store/yr10xbcq4cvwvskd2dlnr384792jqbaw-jfsutils-1.1.15/sbin/jfs_fscklog
shrinking /nix/store/yr10xbcq4cvwvskd2dlnr384792jqbaw-jfsutils-1.1.15/sbin/fsck.jfs
shrinking /nix/store/yr10xbcq4cvwvskd2dlnr384792jqbaw-jfsutils-1.1.15/sbin/jfs_fsck
gzipping man pages under /nix/store/yr10xbcq4cvwvskd2dlnr384792jqbaw-jfsutils-1.1.15/share/man/
strip is /nix/store/8ka8xfsc330vavalzkpsl2war3hfavb4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yr10xbcq4cvwvskd2dlnr384792jqbaw-jfsutils-1.1.15/sbin
patching script interpreter paths in /nix/store/yr10xbcq4cvwvskd2dlnr384792jqbaw-jfsutils-1.1.15
checking for references to /build/ in /nix/store/yr10xbcq4cvwvskd2dlnr384792jqbaw-jfsutils-1.1.15...
moving /nix/store/yr10xbcq4cvwvskd2dlnr384792jqbaw-jfsutils-1.1.15/sbin/* to /nix/store/yr10xbcq4cvwvskd2dlnr384792jqbaw-jfsutils-1.1.15/bin
/nix/store/yr10xbcq4cvwvskd2dlnr384792jqbaw-jfsutils-1.1.15

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jfsutils

Partial log (click to expand)

shrinking /nix/store/szrhyyxdb0dak0dddmnjispj7gyn3d24-jfsutils-1.1.15/sbin/jfs_logdump
shrinking /nix/store/szrhyyxdb0dak0dddmnjispj7gyn3d24-jfsutils-1.1.15/sbin/jfs_fsck
shrinking /nix/store/szrhyyxdb0dak0dddmnjispj7gyn3d24-jfsutils-1.1.15/sbin/jfs_debugfs
shrinking /nix/store/szrhyyxdb0dak0dddmnjispj7gyn3d24-jfsutils-1.1.15/sbin/fsck.jfs
gzipping man pages under /nix/store/szrhyyxdb0dak0dddmnjispj7gyn3d24-jfsutils-1.1.15/share/man/
strip is /nix/store/s2w9vjvw4m3g4cg0g7kc89nxrb8i6amm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/szrhyyxdb0dak0dddmnjispj7gyn3d24-jfsutils-1.1.15/sbin
patching script interpreter paths in /nix/store/szrhyyxdb0dak0dddmnjispj7gyn3d24-jfsutils-1.1.15
checking for references to /build/ in /nix/store/szrhyyxdb0dak0dddmnjispj7gyn3d24-jfsutils-1.1.15...
moving /nix/store/szrhyyxdb0dak0dddmnjispj7gyn3d24-jfsutils-1.1.15/sbin/* to /nix/store/szrhyyxdb0dak0dddmnjispj7gyn3d24-jfsutils-1.1.15/bin

@Ericson2314
Copy link
Member

I'd merge, but this can go to master?

@Mic92
Copy link
Member

Mic92 commented Nov 29, 2018

Merged in 98a2a5b

@Mic92 Mic92 closed this Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@dtzWill dtzWill dtzWill left review comments

@Ericson2314 Ericson2314 Ericson2314 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eburimu @Mic92 @GrahamcOfBorg @Ericson2314 @dtzWill