Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reiserfsprogs: fix cross compilation #51144

Closed
wants to merge 2 commits into from
Closed

reiserfsprogs: fix cross compilation #51144

wants to merge 2 commits into from

Conversation

eburimu
Copy link
Contributor

@eburimu eburimu commented Nov 27, 2018

Motivation for this change

Fixes #51132

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title fix reiserfsprogs cross compilation reiserfsprogs: fix cross compilation Nov 27, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 27, 2018

@GrahamcOfBorg build reiserfsprogs

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: reiserfsprogs

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: reiserfsprogs

Partial log (click to expand)

shrinking /nix/store/qs6npmfhz333sc1avsgyrkfzjpi55k4g-reiserfsprogs-3.6.24/sbin/resize_reiserfs
shrinking /nix/store/qs6npmfhz333sc1avsgyrkfzjpi55k4g-reiserfsprogs-3.6.24/sbin/debugreiserfs
shrinking /nix/store/qs6npmfhz333sc1avsgyrkfzjpi55k4g-reiserfsprogs-3.6.24/sbin/reiserfsck
gzipping man pages under /nix/store/qs6npmfhz333sc1avsgyrkfzjpi55k4g-reiserfsprogs-3.6.24/share/man/
strip is /nix/store/8ka8xfsc330vavalzkpsl2war3hfavb4-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qs6npmfhz333sc1avsgyrkfzjpi55k4g-reiserfsprogs-3.6.24/sbin
patching script interpreter paths in /nix/store/qs6npmfhz333sc1avsgyrkfzjpi55k4g-reiserfsprogs-3.6.24
checking for references to /build/ in /nix/store/qs6npmfhz333sc1avsgyrkfzjpi55k4g-reiserfsprogs-3.6.24...
moving /nix/store/qs6npmfhz333sc1avsgyrkfzjpi55k4g-reiserfsprogs-3.6.24/sbin/* to /nix/store/qs6npmfhz333sc1avsgyrkfzjpi55k4g-reiserfsprogs-3.6.24/bin
/nix/store/qs6npmfhz333sc1avsgyrkfzjpi55k4g-reiserfsprogs-3.6.24

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: reiserfsprogs

Partial log (click to expand)

shrinking /nix/store/37raq63y32jy2vs6kd83iyhwg7ygs8w5-reiserfsprogs-3.6.24/sbin/mkreiserfs
shrinking /nix/store/37raq63y32jy2vs6kd83iyhwg7ygs8w5-reiserfsprogs-3.6.24/sbin/reiserfstune
shrinking /nix/store/37raq63y32jy2vs6kd83iyhwg7ygs8w5-reiserfsprogs-3.6.24/sbin/reiserfsck
gzipping man pages under /nix/store/37raq63y32jy2vs6kd83iyhwg7ygs8w5-reiserfsprogs-3.6.24/share/man/
strip is /nix/store/s2w9vjvw4m3g4cg0g7kc89nxrb8i6amm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/37raq63y32jy2vs6kd83iyhwg7ygs8w5-reiserfsprogs-3.6.24/sbin
patching script interpreter paths in /nix/store/37raq63y32jy2vs6kd83iyhwg7ygs8w5-reiserfsprogs-3.6.24
checking for references to /build/ in /nix/store/37raq63y32jy2vs6kd83iyhwg7ygs8w5-reiserfsprogs-3.6.24...
moving /nix/store/37raq63y32jy2vs6kd83iyhwg7ygs8w5-reiserfsprogs-3.6.24/sbin/* to /nix/store/37raq63y32jy2vs6kd83iyhwg7ygs8w5-reiserfsprogs-3.6.24/bin
/nix/store/37raq63y32jy2vs6kd83iyhwg7ygs8w5-reiserfsprogs-3.6.24

Ericson2314
Ericson2314 approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Ericson2314
Copy link
Member

I'd merge, but looks like this could go to master?

@eburimu
Copy link
Contributor Author

eburimu commented Nov 29, 2018 •
edited

@Ericson2314 OK, fixd the patch, now you can merge.

@Ericson2314
Copy link
Member

Failure looks unrelated, but want to rebase/remerged with master if it's fixed just in case? Sorry about that.

@Mic92
Copy link
Member

Mic92 commented Nov 29, 2018

merged in cfb184f

@Mic92 Mic92 closed this Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@Ericson2314 Ericson2314 Ericson2314 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eburimu @Mic92 @GrahamcOfBorg @Ericson2314