Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3559a6430eae
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 56aac496ffd2
Choose a head ref
  • 3 commits
  • 5 files changed
  • 3 contributors

Commits on Nov 25, 2018

  1. curl: cherry-pick upstream patch for ipv6 url parsing

    Upstream bug: curl/curl#3218.
    
    This causes nixos/tests/ipv6.nix to fix since the last staging merge.
    
    (cherry picked from commit 90720d0)
    In the end I decided to pick it directly without staging,
    so that the various security fixes get to stable* channels fast.
    delroth authored and vcunat committed Nov 25, 2018
    Copy the full SHA
    a7fd431 View commit details

Commits on Nov 27, 2018

  1. nixopsUnstable: 1.6.1pre2622_f10999a -> 1.6.1pre2706_d5ad09c

    This fixes evaluation with the latest master.
    
    (cherry picked from commit cbea220)
    Mic92 committed Nov 27, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    f3fbb85 View commit details
  2. sssd: fix build with updated curl-7.62

    Fixes #51106.
    
    (cherry picked from commit 439bf86)
    The patch seems very safe to pick.
    vcunat committed Nov 27, 2018
    Copy the full SHA
    56aac49 View commit details
10 changes: 9 additions & 1 deletion pkgs/os-specific/linux/sssd/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ stdenv, fetchurl, pkgs, glibc, augeas, dnsutils, c-ares, curl,
{ stdenv, fetchurl, fetchpatch, pkgs, glibc, augeas, dnsutils, c-ares, curl,
cyrus_sasl, ding-libs, libnl, libunistring, nss, samba, nfs-utils, doxygen,
python, python3, pam, popt, talloc, tdb, tevent, pkgconfig, ldb, openldap,
pcre, kerberos, cifs-utils, glib, keyutils, dbus, fakeroot, libxslt, libxml2,
@@ -18,6 +18,14 @@ stdenv.mkDerivation rec {
sha256 = "032ppk57qs1lnvz7pb7lw9ldwm9i1yagh9fzgqgn6na3bg61ynzy";
};

patches = [
(fetchpatch {
name = "duplicate-case-value.diff";
url = "https://github.com/SSSD/sssd/commit/1ee12b05570fcfb8.diff";
sha256 = "01y8i8cfs2gydn84097cl5fynx0db8b0vr345gh57ypp84in3ixw";
})
];

# Something is looking for <libxml/foo.h> instead of <libxml2/libxml/foo.h>
NIX_CFLAGS_COMPILE = "-I${libxml2.dev}/include/libxml2";

5 changes: 5 additions & 0 deletions pkgs/tools/networking/curl/default.nix
Original file line number Diff line number Diff line change
@@ -34,6 +34,11 @@ stdenv.mkDerivation rec {
sha256 = "084niy7cin13ba65p8x38w2xcyc54n3fgzbin40fa2shfr0ca0kq";
};

patches = [
# Cherry picked fix for https://github.com/curl/curl/issues/3218
./fix-ipv6-url-parsing.patch
];

outputs = [ "bin" "dev" "out" "man" "devdoc" ];
separateDebugInfo = stdenv.isLinux;

54 changes: 54 additions & 0 deletions pkgs/tools/networking/curl/fix-ipv6-url-parsing.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
From b28094833a971870fd8c07960b3b12bf6fbbaad3 Mon Sep 17 00:00:00 2001
From: Daniel Stenberg <daniel@haxx.se>
Date: Fri, 2 Nov 2018 15:11:16 +0100
Subject: [PATCH] URL: fix IPv6 numeral address parser

Regression from 46e164069d1a52. Extended test 1560 to verify.

Reported-by: tpaukrt on github
Fixes #3218
Closes #3219
---
lib/urlapi.c | 8 ++++++--
tests/libtest/lib1560.c | 9 +++++++++
2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/lib/urlapi.c b/lib/urlapi.c
index c53e523434..18a6076fff 100644
--- a/lib/urlapi.c
+++ b/lib/urlapi.c
@@ -499,8 +499,12 @@ static CURLUcode parse_port(struct Curl_URL *u, char *hostname)
(']' == endbracket)) {
/* this is a RFC2732-style specified IP-address */
portptr = &hostname[len];
- if (*portptr != ':')
- return CURLUE_MALFORMED_INPUT;
+ if(*portptr) {
+ if(*portptr != ':')
+ return CURLUE_MALFORMED_INPUT;
+ }
+ else
+ portptr = NULL;
}
else
portptr = strchr(hostname, ':');
diff --git a/tests/libtest/lib1560.c b/tests/libtest/lib1560.c
index e0faa12b29..57469a9063 100644
--- a/tests/libtest/lib1560.c
+++ b/tests/libtest/lib1560.c
@@ -128,6 +128,15 @@ struct querycase {
};

static struct testcase get_parts_list[] ={
+ {"http://[fd00:a41::50]:8080",
+ "http | [11] | [12] | [13] | [fd00:a41::50] | 8080 | / | [16] | [17]",
+ CURLU_DEFAULT_SCHEME, 0, CURLUE_OK},
+ {"http://[fd00:a41::50]/",
+ "http | [11] | [12] | [13] | [fd00:a41::50] | [15] | / | [16] | [17]",
+ CURLU_DEFAULT_SCHEME, 0, CURLUE_OK},
+ {"http://[fd00:a41::50]",
+ "http | [11] | [12] | [13] | [fd00:a41::50] | [15] | / | [16] | [17]",
+ CURLU_DEFAULT_SCHEME, 0, CURLUE_OK},
{"https://[::1%252]:1234",
"https | [11] | [12] | [13] | [::1%252] | 1234 | / | [16] | [17]",
CURLU_DEFAULT_SCHEME, 0, CURLUE_OK},
1 change: 1 addition & 0 deletions pkgs/tools/package-management/nixops/generic.nix
Original file line number Diff line number Diff line change
@@ -26,6 +26,7 @@ python2Packages.buildPythonApplication {
datadog
digital-ocean
libvirt
typing
];

doCheck = false;
6 changes: 3 additions & 3 deletions pkgs/tools/package-management/nixops/unstable.nix
Original file line number Diff line number Diff line change
@@ -5,9 +5,9 @@
# Then copy the URL to the tarball.

callPackage ./generic.nix (rec {
version = "1.6.1pre2622_f10999a";
version = "1.6.1pre2706_d5ad09c";
src = fetchurl {
url = "https://hydra.nixos.org/build/73716350/download/2/nixops-${version}.tar.bz2";
sha256 = "08886b6vxhjc3cp0ikxp920zap7wp6r92763fp785rvxrmb00rbd";
url = "https://hydra.nixos.org/build/84098258/download/2/nixops-${version}.tar.bz2";
sha256 = "0lr963a0bjrblv0d1nfl4d0p76jkq6l9xj3vxgzg38q0ld5qw345";
};
})