Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding xnd packages: libndtypes, ndtypes, libxnd, xnd, libgumath, gumath #51151

Merged
merged 6 commits into from Feb 23, 2019
Merged

Adding xnd packages: libndtypes, ndtypes, libxnd, xnd, libgumath, gumath #51151

merged 6 commits into from Feb 23, 2019

Conversation

costrouc
Copy link
Member

Motivation for this change

Packages that have hopes of being a future replacement for numpy.

Things done

libgumath: init at unstable-2018-11-27

libxnd: 0.2.0dev3 -> unstable-2018-11-27

libndtypes: 0.2.0dev3 -> unstable-2018-11-27

pythonPackages.ndtypes: init at unstable-2018-11-27

pythonPackages.xnd: init at unstable-2018-11-27

pythonPackages.gumath: init at unstable-2018-11-27

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner November 27, 2018 23:27
@costrouc costrouc force-pushed the costrouc/add-xnd-python-supprt branch from 28961e3 to 64d6dec Compare November 27, 2018 23:30
@costrouc
Copy link
Member Author

@GrahamcOfBorg build libgumath libndtypes libxnd python3Packages.ndtypes python3Packages.xnd python3Packages.gumath

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libgumath, libndtypes, libxnd, python3Packages.ndtypes, python3Packages.xnd, python3Packages.gumath

Partial log (click to expand)

----------------------------------------------------------------------
Ran 27 tests in 0.699s

OK
/nix/store/df4ql8n6gdjraghpp9vygbbzd9myryl9-libgumath
/nix/store/cazw6yrna32wxjnkwj2y8y2vf2qicz56-libndtypes-unstable-2018-11-27
/nix/store/x6dxch2fzmxvdsjps3jaa8drvm5qh73v-libxnd-unstable-2018-11-27
/nix/store/6klflvz69zm2d55qw0j2swflhnwv4a5i-python3.7-ndtypes-unstable-2018-11-27
/nix/store/ydk0pxg393lpl8a67ra1kvkiyfzbknz1-python3.7-xnd-unstable-2018-11-27
/nix/store/6fvzhmgimh9vnkmqxb5f203hhzxh4jbg-python3.7-gumath-unstable-2018-11-27

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: libgumath, libndtypes, libxnd, python3Packages.ndtypes, python3Packages.xnd, python3Packages.gumath

Partial log (click to expand)

  File "python/test_gumath.py", line 392, in test_acos_opt
    self.assertEqual(y, b)
AssertionError: xnd([1.5707963267948966, 1.47062890563333[101 chars]t64') != [1.5707963267948966, 1.4706289056333368, [85 chars]None]

----------------------------------------------------------------------
Ran 27 tests in 2.594s

FAILED (failures=1)
builder for '/nix/store/dypkzap71wlwf2zj2q90xxpv6wv0pg69-python3.7-gumath-unstable-2018-11-27.drv' failed with exit code 1
error: build of '/nix/store/dypkzap71wlwf2zj2q90xxpv6wv0pg69-python3.7-gumath-unstable-2018-11-27.drv' failed

@costrouc
Copy link
Member Author

Looks like aarch64 fails due to roundoff error. Ready for review

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libgumath, libndtypes, libxnd

Partial log (click to expand)

/nix/store/x3ddag1pvws60agwhqz4cc485vpl2h4p-libgumath
/nix/store/h6vzha4pl9iyfk9z0xak72x00fj4h7dp-libndtypes-unstable-2018-11-27
/nix/store/kmiv3n1cncxynmd5rsmv03y8kk3d6y11-libxnd-unstable-2018-11-27

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libgumath, libndtypes, libxnd

Partial log (click to expand)

/nix/store/df4ql8n6gdjraghpp9vygbbzd9myryl9-libgumath
/nix/store/cazw6yrna32wxjnkwj2y8y2vf2qicz56-libndtypes-unstable-2018-11-27
/nix/store/x6dxch2fzmxvdsjps3jaa8drvm5qh73v-libxnd-unstable-2018-11-27

@costrouc costrouc force-pushed the costrouc/add-xnd-python-supprt branch from 64d6dec to 636c93e Compare December 2, 2018 12:36
@Mic92 Mic92 requested a review from timokau December 2, 2018 17:31
@timokau
Copy link
Member

timokau commented Dec 2, 2018

I haven't heard of these and unfortunately don't have time to look at this in depth right now. I don't see much reason not to include them though, except maybe that they are still unstable.

@costrouc
Copy link
Member Author

costrouc commented Dec 2, 2018

I am one of the developers behind xnd and it is a fast moving project right now so I wanted to include the latest "stable" release. But everything works in this relase.

@costrouc costrouc force-pushed the costrouc/add-xnd-python-supprt branch from 636c93e to 9c05451 Compare December 3, 2018 02:33
@costrouc costrouc force-pushed the costrouc/add-xnd-python-supprt branch from 9c05451 to a78e84d Compare February 3, 2019 13:52
@costrouc
Copy link
Member Author

costrouc commented Feb 3, 2019

Bump. Changes made and ready for merge.

@costrouc costrouc force-pushed the costrouc/add-xnd-python-supprt branch from a78e84d to bc95e95 Compare February 23, 2019 03:16
@costrouc
Copy link
Member Author

@GrahamcOfBorg build python3Packages.gumath

@costrouc
Copy link
Member Author

gumath depends on all the new packages thus if it builds all deps build.

@FRidh
Copy link
Member

FRidh commented Feb 23, 2019

I really like having this in Nixpkgs, thanks.

@costrouc costrouc force-pushed the costrouc/add-xnd-python-supprt branch from bc95e95 to 078ea7f Compare February 23, 2019 17:52
@costrouc costrouc force-pushed the costrouc/add-xnd-python-supprt branch from 078ea7f to 1223c8f Compare February 23, 2019 18:09
@costrouc
Copy link
Member Author

@GrahamcOfBorg build python3Packages.gumath

@costrouc
Copy link
Member Author

Fixed ready for merge

@FRidh FRidh merged commit 161122f into NixOS:master Feb 23, 2019
teh
teh reviewed Feb 23, 2019
View reviewed changes
Copy link
Contributor

@teh teh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add a meta section (with license etc) to the python modules?

@costrouc
Copy link
Member Author

Right now they inherit the meta from their c compiled libraries they are based on. Are you suggesting a python decryption for the package?

@teh
Copy link
Contributor

teh commented Feb 24, 2019

Right - I had missed the meta inherit. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@teh teh teh left review comments

@FRidh FRidh FRidh left review comments

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@costrouc @GrahamcOfBorg @timokau @FRidh @teh @Mic92