Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdns-recursor: 4.1.7 -> 4.1.8 (security) #51138

Merged
merged 1 commit into from
Nov 27, 2018
Merged

pdns-recursor: 4.1.7 -> 4.1.8 (security) #51138

merged 1 commit into from
Nov 27, 2018
+2 −2

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 27, 2018

https://docs.powerdns.com/recursor/changelog/4.1.html#change-4.1.8

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@c0bw3b c0bw3b added 1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 27, 2018
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 27, 2018

Someone must be busy fuzzing DNS implementations.

@dtzWill have you tested building it?

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 27, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pdns-recursor

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pdns-recursor

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/pmagwnqcn5p6ywxamb85zig1sy5r0746-pdns-recursor-4.1.8
shrinking /nix/store/pmagwnqcn5p6ywxamb85zig1sy5r0746-pdns-recursor-4.1.8/bin/rec_control
shrinking /nix/store/pmagwnqcn5p6ywxamb85zig1sy5r0746-pdns-recursor-4.1.8/sbin/pdns_recursor
gzipping man pages under /nix/store/pmagwnqcn5p6ywxamb85zig1sy5r0746-pdns-recursor-4.1.8/share/man/
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pmagwnqcn5p6ywxamb85zig1sy5r0746-pdns-recursor-4.1.8/bin  /nix/store/pmagwnqcn5p6ywxamb85zig1sy5r0746-pdns-recursor-4.1.8/sbin
patching script interpreter paths in /nix/store/pmagwnqcn5p6ywxamb85zig1sy5r0746-pdns-recursor-4.1.8
checking for references to /build in /nix/store/pmagwnqcn5p6ywxamb85zig1sy5r0746-pdns-recursor-4.1.8...
moving /nix/store/pmagwnqcn5p6ywxamb85zig1sy5r0746-pdns-recursor-4.1.8/sbin/* to /nix/store/pmagwnqcn5p6ywxamb85zig1sy5r0746-pdns-recursor-4.1.8/bin
/nix/store/pmagwnqcn5p6ywxamb85zig1sy5r0746-pdns-recursor-4.1.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pdns-recursor

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/1vjnkiixy7zyag8dhyz76ky3mh3j6ykx-pdns-recursor-4.1.8
shrinking /nix/store/1vjnkiixy7zyag8dhyz76ky3mh3j6ykx-pdns-recursor-4.1.8/sbin/pdns_recursor
shrinking /nix/store/1vjnkiixy7zyag8dhyz76ky3mh3j6ykx-pdns-recursor-4.1.8/bin/rec_control
gzipping man pages under /nix/store/1vjnkiixy7zyag8dhyz76ky3mh3j6ykx-pdns-recursor-4.1.8/share/man/
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1vjnkiixy7zyag8dhyz76ky3mh3j6ykx-pdns-recursor-4.1.8/bin  /nix/store/1vjnkiixy7zyag8dhyz76ky3mh3j6ykx-pdns-recursor-4.1.8/sbin
patching script interpreter paths in /nix/store/1vjnkiixy7zyag8dhyz76ky3mh3j6ykx-pdns-recursor-4.1.8
checking for references to /build in /nix/store/1vjnkiixy7zyag8dhyz76ky3mh3j6ykx-pdns-recursor-4.1.8...
moving /nix/store/1vjnkiixy7zyag8dhyz76ky3mh3j6ykx-pdns-recursor-4.1.8/sbin/* to /nix/store/1vjnkiixy7zyag8dhyz76ky3mh3j6ykx-pdns-recursor-4.1.8/bin
/nix/store/1vjnkiixy7zyag8dhyz76ky3mh3j6ykx-pdns-recursor-4.1.8

@dtzWill
Copy link
Member Author

dtzWill commented Nov 27, 2018

Yes, sorry for not indicating as such--my build hadn't completed at the time and I forgot to come back when it was done. 😇

@c0bw3b c0bw3b merged commit 4a95806 into NixOS:master Nov 27, 2018
@c0bw3b c0bw3b mentioned this pull request Nov 27, 2018
Merged
10 tasks
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @c0bw3b @GrahamcOfBorg @samueldr