New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitAndTools.git-reparent: init at 2018-11-27 #51157
Conversation
|
||
stdenv.mkDerivation rec { | ||
name = "git-reparent-${version}"; | ||
version = "2018-11-27"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit itself is from 2017-09-03, so it would maybe be a better date to set as a version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, updated
dontBuild = true; | ||
|
||
installPhase = '' | ||
install -Dpm755 -D git-reparent $out/bin/git-reparent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK there is no need for having twice the -D
option. Also,-p
is a no-op in nix builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
74d2e86
to
1fc0eee
Compare
@GrahamcOfBorg build gitAndTools.git-reparent |
Success on x86_64-linux (full log) Attempted: gitAndTools.git-reparent Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: gitAndTools.git-reparent Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: gitAndTools.git-reparent Partial log (click to expand)
|
Thank you! |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)