Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sure: 1.2.24 -> 1.4.11 #51140

Merged
merged 1 commit into from Nov 27, 2018
Merged

pythonPackages.sure: 1.2.24 -> 1.4.11 #51140

merged 1 commit into from Nov 27, 2018

Conversation

costrouc
Copy link
Member

Fix broken python package sure

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner November 27, 2018 20:11
@costrouc
Copy link
Member Author

@GrahamcOfBorg build python2Packages.sure python3Packages.sure

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.sure, python3Packages.sure

Partial log (click to expand)

safe_repr should return a sorted repr ... ok
test_safe_repr.test_nested_dict
dicts nested inside values should also get sorted ... ok
test_safe_repr.test_unicode
dicts with unicode should work properly ... ok

----------------------------------------------------------------------
Ran 142 tests in 0.813s

OK

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.sure, python3Packages.sure

Partial log (click to expand)

safe_repr should return a sorted repr ... ok
test_safe_repr.test_nested_dict
dicts nested inside values should also get sorted ... ok
test_safe_repr.test_unicode
dicts with unicode should work properly ... ok

----------------------------------------------------------------------
Ran 142 tests in 0.906s

OK

@worldofpeace
Copy link
Contributor

worldofpeace commented Nov 27, 2018 •
edited

I can't connect to the homepage in the meta, so I think we should change it to https://sure.readthedocs.io/en/latest/

Also here's the Changelog.
Looks like this really needed an update since the prior version isn't even documented.

@worldofpeace worldofpeace self-assigned this Nov 27, 2018
@costrouc
Copy link
Member Author

I'll will do that. Should I rebase to staging?

@worldofpeace
Copy link
Contributor

I'll will do that. Should I rebase to staging?

I've inquired and usually 500+ rebuilds go to staging, so master should be fine.

@costrouc
pythonPackages.sure: 1.2.24 -> 1.4.11
12d4cc1 
Fix broken python package `sure`
@costrouc
Copy link
Member Author

@GrahamcOfBorg build python2Packages.sure python3Packages.sure

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.sure, python3Packages.sure

Partial log (click to expand)

safe_repr should return a sorted repr ... ok
test_safe_repr.test_nested_dict
dicts nested inside values should also get sorted ... ok
test_safe_repr.test_unicode
dicts with unicode should work properly ... ok

----------------------------------------------------------------------
Ran 142 tests in 0.917s

OK

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.sure, python3Packages.sure

Partial log (click to expand)

safe_repr should return a sorted repr ... ok
test_safe_repr.test_nested_dict
dicts nested inside values should also get sorted ... ok
test_safe_repr.test_unicode
dicts with unicode should work properly ... ok

----------------------------------------------------------------------
Ran 142 tests in 1.075s

OK

@costrouc
Copy link
Member Author

@worldofpeace fixed and ready for merge.

worldofpeace
worldofpeace approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merging at will.

@worldofpeace worldofpeace merged commit 544d060 into NixOS:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@worldofpeace worldofpeace

Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@costrouc @GrahamcOfBorg @worldofpeace