deployment keys: disable service if no key destinations are in /run/ #1057
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jslight90
force-pushed
the
deployment.keys
branch
from
a0b95d5 to
c9c8ade
Compare
|
I removed the usage of |
ryantm
approved these changes
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nixops-keysservice only needs to be enabled if the destination of one or more keys is a volatile directory (/run/).This was causing an issue for me with the nixpkgs httpd (apache2) module. Said module creates a systemd service dependent on
keys.target. I don't use deployment keys with httpd, but I do have other nixops modules with deployment keys whose destinations are non-volatile (not in/run/). When restarting the server locally (not with nixops), thenixops-keysservice just waits for/run/keys/doneto be created, so httpd won't start. In order to start httpd, I have to use nixops to resend the keys that the system already has.