Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaru: init at 18.10.7 #51153

Closed
wants to merge 1 commit into from
Closed

yaru: init at 18.10.7 #51153

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 28, 2018

Motivation for this change

Community theme(s) from Ubuntu.

GTK and icon themes (Saru?) appear to work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

patchShebangs $x
done
'';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add propagatedUserEnvPkgs = [ gtk-engine-murrine ]; so we don't hit #16268

};

nativeBuildInputs = [ meson ninja sassc python3 ];
buildInputs = [ gtk3 ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
buildInputs = [ gtk3 ];
buildInputs = [ gtk3 gnome3.gnome-themes-extra ];

I think so because it's in debian control

@@ -22822,6 +22822,8 @@ with pkgs;

yara = callPackage ../tools/security/yara { };

yaru-theme = callPackage ../misc/themes/yaru { };
Copy link
Contributor

@c0bw3b c0bw3b Dec 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That line should be relocated in the ### DATA section.

Could we also have this derivation live under pkgs/data/themes (next to icons, fonts and such).
I know that ATM most other themes are under pkgs/misc/themes but it really is data in the end. And that top-level misc is too generic for anything.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 3, 2018

Consider adding that patch also:
ubuntu/yaru@1015ec3

It fixes an issue with Gnome 3.30 (ubuntu/yaru#914)

@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

Are there any updates on this pull request, please?

@worldofpeace
Copy link
Contributor

worldofpeace commented Aug 13, 2019

It has been many months, I'm sure @dtzWill would re-pr if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants