-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yaru: init at 18.10.7 #51153
yaru: init at 18.10.7 #51153
Conversation
patchShebangs $x | ||
done | ||
''; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add propagatedUserEnvPkgs = [ gtk-engine-murrine ];
so we don't hit #16268
}; | ||
|
||
nativeBuildInputs = [ meson ninja sassc python3 ]; | ||
buildInputs = [ gtk3 ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildInputs = [ gtk3 ]; | |
buildInputs = [ gtk3 gnome3.gnome-themes-extra ]; |
I think so because it's in debian control
@@ -22822,6 +22822,8 @@ with pkgs; | |||
|
|||
yara = callPackage ../tools/security/yara { }; | |||
|
|||
yaru-theme = callPackage ../misc/themes/yaru { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That line should be relocated in the ### DATA
section.
Could we also have this derivation live under pkgs/data/themes
(next to icons, fonts and such).
I know that ATM most other themes are under pkgs/misc/themes
but it really is data in the end. And that top-level misc
is too generic for anything.
Consider adding that patch also: It fixes an issue with Gnome 3.30 (ubuntu/yaru#914) |
Are there any updates on this pull request, please? |
It has been many months, I'm sure @dtzWill would re-pr if needed. |
Motivation for this change
Community theme(s) from Ubuntu.
GTK and icon themes (Saru?) appear to work.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)