(18.09) postgresql: Enable systemd integration for 9.6+ #51137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows, finally, proper detection when postgresql is ready to accept connections. Until now, it was possible that services depending on postgresql would fail in a race condition trying to connect to postgresql. (cherry picked from commit d04fedd) Signed-off-by: Domen Kožar <domen@dev.si>
domenkozar
requested review from
basvandijk,
edolstra,
edwtjo,
Ericson2314,
FRidh,
infinisil,
LnL7,
matthewbauer,
Mic92,
nbp,
peti,
Profpatsch,
ryantm,
thoughtpolice,
ttuegel and
zimbatm
as code owners
Mic92
removed request for
zimbatm,
thoughtpolice,
ryantm,
matthewbauer,
peti,
edwtjo,
Mic92,
ttuegel,
basvandijk and
LnL7
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: tests.postgresql.postgresql_9_6, tests.postgresql.postgresql_10, tests.postgresql.postgresql_11, tests.postgresql.postgresql_9_5 Partial log (click to expand)
|
|
I need to write a script that output ofborg test commands! |
GrahamcOfBorg
added
10.rebuild-darwin: 101-500
10.rebuild-linux: 501+
and removed
6.topic: emacs
6.topic: erlang
6.topic: GNOME
|
Success on aarch64-linux (full log) Attempted: postgresql Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: postgresql Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: postgresql Partial log (click to expand)
|
|
@Mic92 any objections merging? |
|
Two people came to same patch, it's tested in production. Merged to 18.09 in 4169ce0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd really like to backport this one to 18.09 as it improves reliability.
I ran PostgreSQL nixos tests and will run this from today on in production (on top of 18.09). So give it a day or so.
EDIT: sorry for mass spam :(