hovercraft: 2.0 -> 2.6 #49841
Merged
hovercraft: 2.0 -> 2.6 #49841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move to top-level, use buildPythonApplication
makefu
force-pushed
the
pkgs/hovercraft/update
branch
from
1e92e56
to
75f5fbe
Compare
|
Success on aarch64-linux (full log) Attempted: hovercraft Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: hovercraft Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: hovercraft Partial log (click to expand)
|
|
even the tests run through on aarch64 and darwin! |
| version = "2.6"; | ||
| disabled = ! isPy3k; | ||
|
|
||
| src = fetchFromGitHub { |
There was a problem hiding this comment.
I'm assuming here that the tests weren't distributed at pypi?
There was a problem hiding this comment.
There was a problem hiding this comment.
exactly, i was using pypi before
| description = "Makes impress.js presentations from reStructuredText"; | ||
| homepage = https://github.com/regebro/hovercraft; | ||
| license = licenses.mit; | ||
| maintainers = with maintainers;[ goibhniu makefu ]; |
There was a problem hiding this comment.
Suggested change
| maintainers = with maintainers;[ goibhniu makefu ]; | |
| maintainers = with maintainers; [ goibhniu makefu ]; |
|
Success on aarch64-linux (full log) Attempted: hovercraft Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: hovercraft Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: hovercraft Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
move to top-level, use buildPythonApplication, bump version to 2.6 .
hovercraft tool for creating presentations, not a python library.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)